Issue 10911351: Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData.

Issue 10911351: Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData. (Closed)

Created:
8 years, 3 months ago by Avi (use Gerrit)

Modified:
8 years, 3 months ago

Reviewers:
Ben Goodger (Google), Scott Byer

CC:
chromium-reviews, creis+watch_chromium.org, kkania, jam, joi+watch-content_chromium.org, robertshield, ajwong+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData. BUG=107201 TEST=no visible change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=157438

Patch Set 5 : rebase, fix typo #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -102 lines)			Patch
M	chrome/browser/automation/automation_provider_win.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.h	View		2 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.cc	View		3 chunks	+10 lines, -9 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller.cc	View		4 chunks	+10 lines, -5 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller_browsertest.cc	View		4 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller_unittest.cc	View		4 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.h	View		5 chunks	+9 lines, -10 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.cc	View		8 chunks	+20 lines, -12 lines	0 comments	Download
M	chrome/browser/printing/printing_layout_browsertest.cc	View	1 2 3 4	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/blocked_content/blocked_content_tab_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser_commands.cc	View		3 chunks	+15 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/cocoa/applescript/tab_applescript.mm	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.h	View	1 2 3 4	4 chunks	+0 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_handler.cc	View	1	4 chunks	+19 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_handler_unittest.cc	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc	View		4 chunks	+16 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_notification_types.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Scott Byer

LGTM w/ question. https://codereview.chromium.org/10911351/diff/8001/chrome/browser/ui/tab_contents/tab_contents.cc File chrome/browser/ui/tab_contents/tab_contents.cc (right): https://codereview.chromium.org/10911351/diff/8001/chrome/browser/ui/tab_contents/tab_contents.cc#newcode190 chrome/browser/ui/tab_contents/tab_contents.cc:190: printing::PrintViewManager::CreateForWebContents(contents); Did you intend to reverse ...

8 years, 3 months ago (2012-09-18 17:24:40 UTC) #2

Avi (use Gerrit)

On 2012/09/18 17:24:40, Scott Byer wrote: > Did you intend to reverse the creation order? ...

8 years, 3 months ago (2012-09-18 17:27:26 UTC) #3