chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc - Issue 10911351: Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc

Issue 10911351: Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix typo Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/print_preview/print_preview_handler_unittest.cc ('k') | chrome/common/chrome_notification_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc

index 7d65c1a28bb77f42b10a6b75be369ef0453c2e50..709d2e7ea3062d7cca7455eb5aeac6c32cde3e8e 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc

@@ -63,7 +63,10 @@ TEST_F(PrintPreviewUIUnitTest, PrintPreviewData) {

printing::PrintPreviewTabController::GetInstance();

ASSERT_TRUE(controller);

- initiator_tab->print_view_manager()->PrintPreviewNow();

+ printing::PrintViewManager* print_view_manager =

+ printing::PrintViewManager::FromWebContents(

+ initiator_tab->web_contents());

+ print_view_manager->PrintPreviewNow();

TabContents* preview_tab = controller->GetOrCreatePreviewTab(initiator_tab);

EXPECT_NE(initiator_tab, preview_tab);

@@ -114,7 +117,10 @@ TEST_F(PrintPreviewUIUnitTest, PrintPreviewDraftPages) {

printing::PrintPreviewTabController::GetInstance();

ASSERT_TRUE(controller);

- initiator_tab->print_view_manager()->PrintPreviewNow();

+ printing::PrintViewManager* print_view_manager =

+ printing::PrintViewManager::FromWebContents(

+ initiator_tab->web_contents());

+ print_view_manager->PrintPreviewNow();

TabContents* preview_tab = controller->GetOrCreatePreviewTab(initiator_tab);

EXPECT_NE(initiator_tab, preview_tab);

@@ -172,7 +178,10 @@ TEST_F(PrintPreviewUIUnitTest, GetCurrentPrintPreviewStatus) {

printing::PrintPreviewTabController::GetInstance();

ASSERT_TRUE(controller);

- initiator_tab->print_view_manager()->PrintPreviewNow();

+ printing::PrintViewManager* print_view_manager =

+ printing::PrintViewManager::FromWebContents(

+ initiator_tab->web_contents());

+ print_view_manager->PrintPreviewNow();

TabContents* preview_tab = controller->GetOrCreatePreviewTab(initiator_tab);

EXPECT_NE(initiator_tab, preview_tab);

@@ -235,7 +244,10 @@ TEST_F(PrintPreviewUIUnitTest, InitiatorTabGetsFocusOnPrintPreviewTabClose) {

printing::PrintPreviewTabController::GetInstance();

ASSERT_TRUE(controller);

- initiator_tab->print_view_manager()->PrintPreviewNow();

+ printing::PrintViewManager* print_view_manager =

+ printing::PrintViewManager::FromWebContents(

+ initiator_tab->web_contents());

+ print_view_manager->PrintPreviewNow();

TabContents* preview_tab = controller->GetOrCreatePreviewTab(initiator_tab);

EXPECT_NE(initiator_tab, preview_tab);