chrome/browser/printing/print_preview_tab_controller_browsertest.cc - Issue 10911351: Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/printing/print_preview_tab_controller_browsertest.cc

Issue 10911351: Switch PrintViewManager, PrintPreviewMessageHandler to use WebContentsUserData. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix typo Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_tab_controller.cc ('k') | chrome/browser/printing/print_preview_tab_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/printing/print_preview_tab_controller_browsertest.cc

diff --git a/chrome/browser/printing/print_preview_tab_controller_browsertest.cc b/chrome/browser/printing/print_preview_tab_controller_browsertest.cc

index b2d84425cf60a7eee48d6fb4d2261af06039adf1..d89e433e42bcb7533aebdc4ee3041f13e51075e4 100644

--- a/chrome/browser/printing/print_preview_tab_controller_browsertest.cc

+++ b/chrome/browser/printing/print_preview_tab_controller_browsertest.cc

@@ -66,7 +66,10 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTabControllerBrowserTest,

ASSERT_TRUE(tab_controller);

// Get the preview tab for initiator tab.

- initiator_tab->print_view_manager()->PrintPreviewNow();

+ printing::PrintViewManager* print_view_manager =

+ printing::PrintViewManager::FromWebContents(

+ initiator_tab->web_contents());

+ print_view_manager->PrintPreviewNow();

TabContents* preview_tab =

tab_controller->GetOrCreatePreviewTab(initiator_tab);

@@ -83,7 +86,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTabControllerBrowserTest,

ASSERT_TRUE(observer.tab_destroyed());

// Get the print preview tab for initiator tab.

- initiator_tab->print_view_manager()->PrintPreviewNow();

+ print_view_manager->PrintPreviewNow();

TabContents* new_preview_tab =

tab_controller->GetOrCreatePreviewTab(initiator_tab);

@@ -108,7 +111,10 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTabControllerBrowserTest,

ASSERT_TRUE(tab_controller);

// Get the preview tab for initiator tab.

- initiator_tab->print_view_manager()->PrintPreviewNow();

+ printing::PrintViewManager* print_view_manager =

+ printing::PrintViewManager::FromWebContents(

+ initiator_tab->web_contents());

+ print_view_manager->PrintPreviewNow();

TabContents* preview_tab =

tab_controller->GetOrCreatePreviewTab(initiator_tab);

@@ -128,7 +134,7 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTabControllerBrowserTest,

ASSERT_TRUE(tab_destroyed_observer.tab_destroyed());

// Get the print preview tab for initiator tab.

- initiator_tab->print_view_manager()->PrintPreviewNow();

+ print_view_manager->PrintPreviewNow();

TabContents* new_preview_tab =

tab_controller->GetOrCreatePreviewTab(initiator_tab);