Issue 10910088: Fix host-checked + checked by registering when a class is being instantiated, not when being proces…

Issue 10910088: Fix host-checked + checked by registering when a class is being instantiated, not when being proces… (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix host-checked + checked by registering when a class is being instantiated, not when being processed. Committed: https://code.google.com/p/dart/source/detail?r=11876

Patch Set 4 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -27 lines)			Patch
M	lib/compiler/implementation/compile_time_constants.dart	View	1 2 3	4 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/enqueue.dart	View	1	3 chunks	+17 lines, -16 lines	0 comments	Download
M	lib/compiler/implementation/universe.dart	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://chromiumcodereview.appspot.com/10910088/diff/1/lib/compiler/implementation/enqueue.dart File lib/compiler/implementation/enqueue.dart (left): https://chromiumcodereview.appspot.com/10910088/diff/1/lib/compiler/implementation/enqueue.dart#oldcode174 lib/compiler/implementation/enqueue.dart:174: universe.instantiatedClassInstanceFields.add(member.name); I think this field is unused. Could ...

8 years, 3 months ago (2012-09-05 12:52:04 UTC) #2

ngeoffray

Thanks Peter https://chromiumcodereview.appspot.com/10910088/diff/1/lib/compiler/implementation/enqueue.dart File lib/compiler/implementation/enqueue.dart (left): https://chromiumcodereview.appspot.com/10910088/diff/1/lib/compiler/implementation/enqueue.dart#oldcode174 lib/compiler/implementation/enqueue.dart:174: universe.instantiatedClassInstanceFields.add(member.name); On 2012/09/05 12:52:04, ahe wrote: > ...

8 years, 3 months ago (2012-09-05 12:57:30 UTC) #3

ahe

LGTM https://chromiumcodereview.appspot.com/10910088/diff/4002/lib/compiler/implementation/compile_time_constants.dart File lib/compiler/implementation/compile_time_constants.dart (right): https://chromiumcodereview.appspot.com/10910088/diff/4002/lib/compiler/implementation/compile_time_constants.dart#newcode86 lib/compiler/implementation/compile_time_constants.dart:86: int hashCode() => 17 * element.hashCode(); (...) & ...

8 years, 3 months ago (2012-09-05 13:18:21 UTC) #4

ngeoffray

8 years, 3 months ago (2012-09-05 13:23:27 UTC) #5

:)

https://chromiumcodereview.appspot.com/10910088/diff/4002/lib/compiler/implem...
File lib/compiler/implementation/compile_time_constants.dart (right):

https://chromiumcodereview.appspot.com/10910088/diff/4002/lib/compiler/implem...
lib/compiler/implementation/compile_time_constants.dart:86: int hashCode() => 17
* element.hashCode();
On 2012/09/05 13:18:21, ahe wrote:
> (...) & 0x7fffffff

Done.

Expand Messages | Collapse Messages