Fix host-checked + checked by registering when a class is being instantiated, not when being proces…

lib/compiler/implementation/enqueue.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class EnqueueTask extends CompilerTask {
   final Enqueuer codegen;
   final Enqueuer resolution;
 
   String get name => 'Enqueue';
 
@@ skipping 151 matching lines @@
   }
 
   void processInstantiatedClass(ClassElement cls) {
     cls.localMembers.forEach(processInstantiatedClassMember);
   }
 
   void processInstantiatedClassMember(Element member) {
     if (universe.generatedCode.containsKey(member)) return;
     if (resolvedElements[member] !== null) return;
     if (!member.isInstanceMember()) return;
-
-    if (member.kind === ElementKind.FIELD) {
-      universe.instantiatedClassInstanceFields.add(member.name);

[ahe, 2012/09/05 12:52:04]

I think this field is unused. Could you remove it from universe?

[ngeoffray, 2012/09/05 12:57:30]

Done.

-      if (compiler.enableTypeAssertions) {
-        DartType type = member.computeType(compiler);
-        registerIsCheck(type.element);
-        SourceString helper = compiler.backend.getCheckedModeHelper(type);
-        if (helper != null) {
-          Element helperElement = compiler.findHelper(helper);
-          registerStaticUse(helperElement);
-        }
-      }
-      return;
-    }
+    if (member.isField()) return;
 
     String memberName = member.name.slowToString();
     Link<Element> members = instanceMembersByName.putIfAbsent(
         memberName, () => const EmptyLink<Element>());
     instanceMembersByName[memberName] = members.prepend(member);
 
 
     if (member.kind == ElementKind.FUNCTION) {
       if (member.name == Compiler.NO_SUCH_METHOD) {
         compiler.enableNoSuchMethod(member);
@@ skipping 38 matching lines @@
         cls = supertypes.head.element;
         if (seenClasses.contains(cls)) continue;
         seenClasses.add(cls);
         cls.ensureResolved(compiler);
         if (!cls.isInterface()) {
           cls.localMembers.forEach(processInstantiatedClassMember);
         }
         if (isResolutionQueue) {
           compiler.resolver.checkMembers(cls);
         }
+        
+        if (compiler.enableTypeAssertions) {

[ahe, 2012/09/05 12:52:04]

This still doesn't feel right.

[ngeoffray, 2012/09/05 12:57:30]

Added a TODO.

+          // We need to register is checks and helpers for checking
+          // assignments to fields.
+          cls.localMembers.forEach((Element member) {
+            if (!member.isInstanceMember() && !member.isField()) return;
+            DartType type = member.computeType(compiler);
+            registerIsCheck(type.element);
+            SourceString helper = compiler.backend.getCheckedModeHelper(type);
+            if (helper != null) {
+              Element helperElement = compiler.findHelper(helper);
+              registerStaticUse(helperElement);
+            }
+          });
+        }
       }
     });
   }
 
   void registerNewSelector(SourceString name,
                            Selector selector,
                            Map<SourceString, Set<Selector>> selectorsMap) {
     if (name != selector.name) {
       String message = "$name != ${selector.name} (${selector.kind})";
       compiler.internalError("Wrong selector name: $message.");
@@ skipping 98 matching lines @@
   void registerIsCheck(Element element) {
     universe.isChecks.add(element);
   }
 
   void forEach(f(WorkItem work)) {
     while (!queue.isEmpty()) {
       f(queue.removeLast()); // TODO(kasperl): Why isn't this removeFirst?
     }
   }
 }