Issue 10909144: Reapply change 9663

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10909144: Reapply change 9663 (Closed)

Created:
8 years, 3 months ago by noelallen1

Modified:
8 years, 3 months ago

Reviewers:
bradn, binji

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

Reapply change 9663 Change 9633 had a bug where untrusted.gypi did not specify a -t <toolpath> for cases where nso targets were defined. This CL reapplies the original CL with this two line change in untrusted.gypi See: https://chromiumcodereview.appspot.com/10915109 TBR=binji@google.com Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9683

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -2 lines)			Patch
M	build/all.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/build_nexe.py	View		4 chunks	+8 lines, -1 line	0 comments	Download
A	build/nacl_core_sdk.gyp	View		1 chunk	+39 lines, -0 lines	0 comments	Download
M	build/untrusted.gypi	View	1 2	3 chunks	+84 lines, -0 lines	0 comments	Download
M	src/shared/gio/gio.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/shared/imc/imc.gyp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/shared/platform/platform.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/shared/srpc/srpc.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/trusted/weak_ref/weak_ref.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/untrusted/nacl/nacl.gyp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	src/untrusted/valgrind/valgrind.gyp	View	1	1 chunk	+47 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM