Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 10915109: Add nacl_sdk gyp meta-target. (Closed)

Created:
8 years, 3 months ago by binji
Modified:
8 years, 3 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com, noelallen1
Visibility:
Public.

Description

Add nacl_sdk gyp meta-target. This is a part of the making the nacl_sdk builder use gyp instead of scons. The libraries built should be the same as the libraries build when building the scons install_lib target, excepting the ppapi libraries which will be built on the Chrome side. BUG=none Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=9663

Patch Set 1 #

Total comments: 17

Patch Set 2 : feedback #

Patch Set 3 : rebase on HEAD #

Patch Set 4 : no imc_lib on arm #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -2 lines) Patch
M build/all.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M build/build_nexe.py View 2 chunks +5 lines, -1 line 0 comments Download
A build/nacl_core_sdk.gyp View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
M build/untrusted.gypi View 3 chunks +82 lines, -0 lines 0 comments Download
M src/shared/gio/gio.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/shared/imc/imc.gyp View 1 chunk +2 lines, -1 line 0 comments Download
M src/shared/platform/platform.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/shared/srpc/srpc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/weak_ref/weak_ref.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/untrusted/nacl/nacl.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
A src/untrusted/valgrind/valgrind.gyp View 1 2 3 4 5 6 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
binji
http://codereview.chromium.org/10915109/diff/1/build/untrusted.gypi File build/untrusted.gypi (right): http://codereview.chromium.org/10915109/diff/1/build/untrusted.gypi#newcode562 build/untrusted.gypi:562: }, Copied from the glibc/nlib condition above. Changes are ...
8 years, 3 months ago (2012-09-06 00:34:25 UTC) #1
binji
+noel
8 years, 3 months ago (2012-09-06 01:04:57 UTC) #2
bradn
You're missing the newlib version of nso, and I'm a little unsure about the meta ...
8 years, 3 months ago (2012-09-06 03:00:20 UTC) #3
binji
http://codereview.chromium.org/10915109/diff/1/build/nacl_sdk.gyp File build/nacl_sdk.gyp (right): http://codereview.chromium.org/10915109/diff/1/build/nacl_sdk.gyp#newcode11 build/nacl_sdk.gyp:11: 'target_name': 'nacl_sdk', On 2012/09/06 03:00:21, bradn wrote: > Did ...
8 years, 3 months ago (2012-09-06 18:36:40 UTC) #4
bradn
LGTM :-) good point about newlib
8 years, 3 months ago (2012-09-06 18:41:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/binji@chromium.org/10915109/9004
8 years, 3 months ago (2012-09-07 21:27:57 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-09-08 07:51:50 UTC) #7
Change committed as 9663

Powered by Google App Engine
This is Rietveld 408576698