Clean up copy-and-pasted code in prefs UI classes

Clean up copy-and-pasted code in prefs UI classes

This CL makes all prefs UI classes inherit from a common ancestor,
consolidating previously copy-and-pasted code. As an additional cleanup,
support for checkboxes controlling a non-Boolean pref is retired as no
such checkboxes exist in Chrome's code.

BUG=104955
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154793

[bartfab (slow), 2012-09-03 16:14:28]

Hi James,

Here is the final CL of my prefs clean-up effort. This one addresses all the
copy-and-pasted code in the prefs UI classes.

[James Hawkins, 2012-09-04 14:22:20]

LGTM with some thoughts.

https://chromiumcodereview.appspot.com/10908061/diff/1/chrome/browser/resourc...
File chrome/browser/resources/options/pref_ui.js (right):

https://chromiumcodereview.appspot.com/10908061/diff/1/chrome/browser/resourc...
chrome/browser/resources/options/pref_ui.js:119: * classes that support multiple
different data types.
I think the use of the word 'different' here is superfluous as it's implied by
'multiple'.

https://chromiumcodereview.appspot.com/10908061/diff/1/chrome/browser/resourc...
chrome/browser/resources/options/pref_ui.js:126: * in the settings UI
immediately but are only actually committed when the
Before I forget: do we have code to handle reverting the pref change if the user
manages to close the settings page before confirming the dialog?

[bartfab (slow), 2012-09-04 15:03:29]

https://chromiumcodereview.appspot.com/10908061/diff/1/chrome/browser/resourc...
File chrome/browser/resources/options/pref_ui.js (right):

https://chromiumcodereview.appspot.com/10908061/diff/1/chrome/browser/resourc...
chrome/browser/resources/options/pref_ui.js:119: * classes that support multiple
different data types.
Done. I actually spent some time last night wondering whether "multiple
different" is clearer or needlessy redundant :).

https://chromiumcodereview.appspot.com/10908061/diff/1/chrome/browser/resourc...
chrome/browser/resources/options/pref_ui.js:126: * in the settings UI
immediately but are only actually committed when the
Until you click "OK", the new setting values exist only in the current settings
page's Preferences object. If you just close the page, that object goes away and
the new setting values disappear with it. When you reopen the settings page, a
new Preferences object is constructed that re-reads the settings from Chrome.
For good measure, I just verified that this works as expected.

[commit-bot: I haz the power, 2012-09-04 15:05:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bartfab@chromium.org/10908061/6001

[commit-bot: I haz the power, 2012-09-04 19:24:48]

Change committed as 154793