Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: chrome/tools/extract_actions.py

Issue 10908061: Clean up copy-and-pasted code in prefs UI classes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Nit addressed. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/pref_ui.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/extract_actions.py
diff --git a/chrome/tools/extract_actions.py b/chrome/tools/extract_actions.py
index 1a6c8c18b872a7892db9e72309c260041cd6be21..c040ef25dcb26457dbb5cf1afec287ffa0bde942 100755
--- a/chrome/tools/extract_actions.py
+++ b/chrome/tools/extract_actions.py
@@ -284,10 +284,7 @@ class WebUIActionsParser(HTMLParser):
is_boolean = ('dataType' in attrs and attrs['dataType'] == 'boolean')
if 'type' in attrs and attrs['type'] in ('checkbox', 'radio'):
if attrs['type'] == 'checkbox':
- # Checkboxes are boolean by default. However, their 'value-type' can
- # instead be set to 'integer'.
- if 'value-type' not in attrs or attrs['value-type'] in ['', 'boolean']:
- is_boolean = True
+ is_boolean = True
else:
# Radio buttons are boolean if and only if their values are 'true' or
# 'false'.
« no previous file with comments | « chrome/browser/resources/options/pref_ui.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698