Clean up copy-and-pasted code in prefs UI classes

chrome/tools/extract_actions.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Extract UserMetrics "actions" strings from the Chrome source.
 
 This program generates the list of known actions we expect to see in the
 user behavior logs.  It walks the Chrome source, looking for calls to
 UserMetrics functions, extracting actions and warning on improper calls,
@@ skipping 266 matching lines @@
     attrs = dict(attrs)
     if not 'metric' in attrs:
       return
 
     # Boolean metrics have two corresponding actions.  All other metrics have
     # just one corresponding action.  By default, we check the 'dataType'
     # attribute.
     is_boolean = ('dataType' in attrs and attrs['dataType'] == 'boolean')
     if 'type' in attrs and attrs['type'] in ('checkbox', 'radio'):
       if attrs['type'] == 'checkbox':
-        # Checkboxes are boolean by default.  However, their 'value-type' can
-        # instead be set to 'integer'.
-        if 'value-type' not in attrs or attrs['value-type'] in ['', 'boolean']:
-          is_boolean = True
+        is_boolean = True
       else:
         # Radio buttons are boolean if and only if their values are 'true' or
         # 'false'.
         assert(attrs['type'] == 'radio')
         if 'value' in attrs and attrs['value'] in ['true', 'false']:
           is_boolean = True
 
     if is_boolean:
       self.actions.add(attrs['metric'] + '_Enable')
       self.actions.add(attrs['metric'] + '_Disable')
@@ skipping 142 matching lines @@
     else:
       print action
 
   if hash_output:
     print "Done. Do not forget to add chromeactions.txt to your changelist"
   return 0
 
 
 if '__main__' == __name__:
   sys.exit(main(sys.argv))