Issue 10907021: Fix a memory leak in PasswordGenerationManager.

Issue 10907021: Fix a memory leak in PasswordGenerationManager. (Closed)

Created:
8 years, 3 months ago by Ilya Sherman

Modified:
8 years, 3 months ago

Reviewers:
Lei Zhang, Avi (use Gerrit), Garrett Casto

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, dhollowa+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, dyu1, pam+watch_chromium.org, Ilya Sherman, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix a memory leak in PasswordGenerationManager. Also, update the PasswordFormDomManager interface to return a scoped_ptr<> to help prevent future memory leaks. BUG=145711 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154414

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -31 lines)			Patch
M	chrome/renderer/autofill/password_generation_manager.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/public/renderer/document_state.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/renderer/document_state.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+0 lines, -19 lines	1 comment	Download
M	webkit/forms/password_form_dom_manager.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/forms/password_form_dom_manager.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

Garrett, please take a look at the non-content/ changes. Avi, please take a look at ...

8 years, 3 months ago (2012-08-30 23:46:02 UTC) #1

Garrett Casto

LGTM I was going to deal with this in 10837324, but this is better. I ...

8 years, 3 months ago (2012-08-31 07:19:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10907021/1

8 years, 3 months ago (2012-08-31 07:22:25 UTC) #4

Lei Zhang

8 years, 3 months ago (2012-08-31 17:08:42 UTC) #6

Thanks for fixing this quickly.

https://chromiumcodereview.appspot.com/10907021/diff/1/tools/valgrind/memchec...
File tools/valgrind/memcheck/suppressions.txt (left):

https://chromiumcodereview.appspot.com/10907021/diff/1/tools/valgrind/memchec...
tools/valgrind/memcheck/suppressions.txt:6040: bug_145712
Did you accidentally remove a second suppression here?

Expand Messages | Collapse Messages