Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: content/renderer/render_view_impl.cc

Issue 10907021: Fix a memory leak in PasswordGenerationManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 9639d2e26bfe224a2b7b8d9130b0872ba12da9c4..b32cfa00419e9662529a26c5c0d10281d0066d0c 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2825,16 +2825,15 @@ void RenderViewImpl::willSubmitForm(WebFrame* frame,
document_state->set_searchable_form_url(web_searchable_form_data.url());
document_state->set_searchable_form_encoding(
web_searchable_form_data.encoding().utf8());
- PasswordForm* password_form_data =
+ scoped_ptr<PasswordForm> password_form_data =
PasswordFormDomManager::CreatePasswordForm(form);
- document_state->set_password_form_data(password_form_data);
// In order to save the password that the user actually typed and not one
// that may have gotten transformed by the site prior to submit, recover it
// from the form contents already stored by |willSendSubmitEvent| into the
// dataSource's NavigationState (as opposed to the provisionalDataSource's,
// which is what we're storing into now.)
- if (password_form_data) {
+ if (password_form_data.get()) {
DocumentState* old_document_state =
DocumentState::FromDataSource(frame->dataSource());
if (old_document_state) {
@@ -2844,6 +2843,8 @@ void RenderViewImpl::willSubmitForm(WebFrame* frame,
}
}
+ document_state->set_password_form_data(password_form_data.Pass());
+
FOR_EACH_OBSERVER(
RenderViewObserver, observers_, WillSubmitForm(frame, form));
}

Powered by Google App Engine
This is Rietveld 408576698