Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: webkit/forms/password_form_dom_manager.h

Issue 10907021: Fix a memory leak in PasswordGenerationManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/forms/password_form_dom_manager.h
diff --git a/webkit/forms/password_form_dom_manager.h b/webkit/forms/password_form_dom_manager.h
index 7354dedb4fd62a5284f5919ffa73d39fde211180..30abb7489b1c26a877b07fed0841d9b54508a6bf 100644
--- a/webkit/forms/password_form_dom_manager.h
+++ b/webkit/forms/password_form_dom_manager.h
@@ -7,6 +7,7 @@
#include <map>
+#include "base/memory/scoped_ptr.h"
#include "webkit/forms/form_data.h"
#include "webkit/forms/password_form.h"
#include "webkit/forms/webkit_forms_export.h"
@@ -43,7 +44,7 @@ class PasswordFormDomManager {
// custom metadata to DOM nodes, so we have to do this every time an event
// happens with a given form and compare against previously Create'd forms
// to identify..which sucks.
- WEBKIT_FORMS_EXPORT static PasswordForm* CreatePasswordForm(
+ WEBKIT_FORMS_EXPORT static scoped_ptr<PasswordForm> CreatePasswordForm(
const WebKit::WebFormElement& form);
// Create a FillData structure in preparation for autofilling a form,

Powered by Google App Engine
This is Rietveld 408576698