Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: pkg/unittest/test_case.dart

Issue 10905255: Change Duration to take proper named optional parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/unittest/test_case.dart
diff --git a/pkg/unittest/test_case.dart b/pkg/unittest/test_case.dart
index 35e9ff89c23aa86b3472bd7c2cd0aa39ddce2f5c..b0f1d18e12fc78e0cce396606cb8dcd14fe9a93b 100644
--- a/pkg/unittest/test_case.dart
+++ b/pkg/unittest/test_case.dart
@@ -86,7 +86,7 @@ class TestCase {
// TODO(gram): currently the duration measurement code is blocked
// by issue 4437. When that is fixed replace the line below with:
// runningTime = new Date.now().difference(startTime);
- runningTime = new Duration(milliseconds:0);
+ runningTime = new Duration(milliseconds: 0);
bakster 2012/09/13 09:00:01 How about introducing a static or a named construc
kasperl 2012/09/13 09:04:47 That's fine but that extra constructor will not ma
Lasse Reichstein Nielsen 2012/09/13 09:30:46 Not prevent it, but perhaps it will preempt it by
}
if (!_doneTeardown) {
if (_tearDown != null) {

Powered by Google App Engine
This is Rietveld 408576698