lib/core/duration.dart - Issue 10905255: Change Duration to take proper named optional parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/core/duration.dart

Issue 10905255: Change Duration to take proper named optional parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/core/duration.dart

diff --git a/lib/core/duration.dart b/lib/core/duration.dart

index 91c5959633bf2806469128a6d2553cde80b9ded2..c3bf66b37cffda10e391e1e54276fdcc12b273c8 100644

--- a/lib/core/duration.dart

+++ b/lib/core/duration.dart

@@ -16,8 +16,8 @@ interface Duration extends Comparable default DurationImplementation {

* All individual parts are allowed to be negative.

* All arguments are by default 0.

- const Duration([int days, int hours, int minutes, int seconds,

- int milliseconds]);

+ const Duration({int days, int hours, int minutes, int seconds,

+ int milliseconds});

bakster 2012/09/13 09:00:01 It would be great to have the default values liste

/**

* Returns this [Duration] in days. Incomplete days are discarded.

« no previous file with comments | « lib/compiler/implementation/lib/coreimpl_patch.dart ('k') | lib/coreimpl/duration_implementation.dart » ('j') | pkg/unittest/test_case.dart » ('J')