Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: runtime/lib/date_patch.dart

Issue 10905255: Change Duration to take proper named optional parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/date_patch.dart
diff --git a/runtime/lib/date_patch.dart b/runtime/lib/date_patch.dart
index 914aab83ab665996d402587d057b9280d6a924e5..7898957ad17b1c893e9a4d584d5ea7821ce78015 100644
--- a/runtime/lib/date_patch.dart
+++ b/runtime/lib/date_patch.dart
@@ -31,7 +31,7 @@ patch class DateImplementation {
}
/* patch */ Duration get timeZoneOffset {
- if (isUtc) return new Duration(0);
+ if (isUtc) return new Duration();
Lasse Reichstein Nielsen 2012/09/13 09:30:46 If not introducing the zero-duration, be consisten
kasperl 2012/09/13 09:45:50 I'm reluctant to start refactoring these things wh
int offsetInSeconds = _timeZoneOffsetInSeconds(millisecondsSinceEpoch);
return new Duration(seconds: offsetInSeconds);
}

Powered by Google App Engine
This is Rietveld 408576698