Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: lib/core/duration.dart

Issue 10905255: Change Duration to take proper named optional parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // Dart core library. 5 // Dart core library.
6 6
7 /** 7 /**
8 * A [Duration] represents a time span. A duration can be negative. 8 * A [Duration] represents a time span. A duration can be negative.
9 */ 9 */
10 interface Duration extends Comparable default DurationImplementation { 10 interface Duration extends Comparable default DurationImplementation {
11 /** 11 /**
12 * The duration is the sum of all individual parts. This means that individual 12 * The duration is the sum of all individual parts. This means that individual
13 * parts don't need to be less than the next-bigger unit. For example [hours] 13 * parts don't need to be less than the next-bigger unit. For example [hours]
14 * is allowed to have a value greater than 23. 14 * is allowed to have a value greater than 23.
15 * 15 *
16 * All individual parts are allowed to be negative. 16 * All individual parts are allowed to be negative.
17 * All arguments are by default 0. 17 * All arguments are by default 0.
18 */ 18 */
19 const Duration([int days, int hours, int minutes, int seconds, 19 const Duration({int days, int hours, int minutes, int seconds,
20 int milliseconds]); 20 int milliseconds});
bakster 2012/09/13 09:00:01 It would be great to have the default values liste
21 21
22 /** 22 /**
23 * Returns this [Duration] in days. Incomplete days are discarded. 23 * Returns this [Duration] in days. Incomplete days are discarded.
24 */ 24 */
25 int get inDays; 25 int get inDays;
26 26
27 /** 27 /**
28 * Returns this [Duration] in hours. Incomplete hours are discarded. 28 * Returns this [Duration] in hours. Incomplete hours are discarded.
29 * The returned value can be greater than 23. 29 * The returned value can be greater than 23.
30 */ 30 */
(...skipping 26 matching lines...) Expand all
57 static const int MILLISECONDS_PER_HOUR = 57 static const int MILLISECONDS_PER_HOUR =
58 MILLISECONDS_PER_MINUTE * MINUTES_PER_HOUR; 58 MILLISECONDS_PER_MINUTE * MINUTES_PER_HOUR;
59 static const int MILLISECONDS_PER_DAY = 59 static const int MILLISECONDS_PER_DAY =
60 MILLISECONDS_PER_HOUR * HOURS_PER_DAY; 60 MILLISECONDS_PER_HOUR * HOURS_PER_DAY;
61 61
62 static const int SECONDS_PER_HOUR = SECONDS_PER_MINUTE * MINUTES_PER_HOUR; 62 static const int SECONDS_PER_HOUR = SECONDS_PER_MINUTE * MINUTES_PER_HOUR;
63 static const int SECONDS_PER_DAY = SECONDS_PER_HOUR * HOURS_PER_DAY; 63 static const int SECONDS_PER_DAY = SECONDS_PER_HOUR * HOURS_PER_DAY;
64 64
65 static const int MINUTES_PER_DAY = MINUTES_PER_HOUR * HOURS_PER_DAY; 65 static const int MINUTES_PER_DAY = MINUTES_PER_HOUR * HOURS_PER_DAY;
66 } 66 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698