dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart - Issue 10905211: Clean up operator names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

Issue 10905211: Clean up operator names. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart b/dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

index 8fbb03efbb64a36535799cff08df439b8478626c..eeebafd4b5ac91fe7f369267043f7452d483e02b 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

@@ -1383,7 +1383,11 @@ class Dart2JsMethodMirror extends Dart2JsMemberMirror

factory Dart2JsMethodMirror(Dart2JsContainerMirror objectMirror,

FunctionElement function) {

- String simpleName = function.name.slowToString();

+ String realName = function.name.slowToString();

+ // TODO(ahe): This method should not be calling

+ // Elements.operatorNameToIdentifier.

+ String simpleName =

+ Elements.operatorNameToIdentifier(function.name).slowToString();

String displayName;

String constructorName = null;

String operatorName = null;

@@ -1424,7 +1428,7 @@ class Dart2JsMethodMirror extends Dart2JsMemberMirror

}

// Simple name is TypeName.constructorName.

displayName = simpleName;

- } else if (simpleName == 'negate') {

+ } else if (realName == 'unary-') {

kind = Dart2JsMethodKind.OPERATOR;

operatorName = '-';

// Simple name is 'unary-'.