Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

Issue 10905211: Clean up operator names. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address review comments Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
index 1236aa6d9f53ec48e24144c588f420c7b02b82be..69817be1aaa4dd5b84f84382cdf2a1d0f4366d75 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
@@ -111,7 +111,7 @@ class Namer {
}
String instanceMethodName(FunctionElement element) {
- SourceString name = element.name;
+ SourceString name = Elements.operatorNameToIdentifier(element.name);
LibraryElement lib = element.getLibrary();
if (element.kind == ElementKind.GENERATIVE_CONSTRUCTOR_BODY) {
ConstructorBodyElement bodyElement = element;
@@ -132,12 +132,14 @@ class Namer {
}
String publicInstanceMethodNameByArity(SourceString name, int arity) {
+ name = Elements.operatorNameToIdentifier(name);
assert(!name.isPrivate());
return '${name.slowToString()}\$$arity';
}
String instanceMethodInvocationName(LibraryElement lib, SourceString name,
Selector selector) {
+ name = Elements.operatorNameToIdentifier(name);
// TODO(floitsch): mangle, while preserving uniqueness.
StringBuffer buffer = new StringBuffer();
List<SourceString> names = selector.getOrderedNamedArguments();

Powered by Google App Engine
This is Rietveld 408576698