dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 10905211: Clean up operator names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 10905211: Clean up operator names. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Address review comments Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart ('k') | dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart b/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

index 1ebc7109cef5b0c72cf723b88ccd8b9772ae05cf..2759c3475833a3d7ce34171153876f92b7d1f017 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart

@@ -1615,12 +1615,17 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {

if (node.isOperator) {

SourceString source = node.selector.asOperator().source;

String string = source.stringValue;

- if (identical(string, '!') || identical(string, '&&') || string == '||' ||

- identical(string, 'is') || identical(string, 'as') ||

+ if (identical(string, '!') ||

+ identical(string, '&&') || identical(string, '||') ||

+ identical(string, 'is') || identical(string, 'as') ||

identical(string, '===') || identical(string, '!==') ||

+ identical(string, '?') ||

identical(string, '>>>')) {

return null;

}

+ if (!isUserDefinableOperator(source.stringValue)) {

+ source = Elements.mapToUserOperator(source);

+ }

return node.arguments.isEmpty

? new Selector.unaryOperator(source)

: new Selector.binaryOperator(source);