Issue 10905019: Separate Dart backend specific logic from basic Unparser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10905019: Separate Dart backend specific logic from basic Unparser. (Closed)

Created:
8 years, 3 months ago by Anton Muhin

Modified:
8 years, 2 months ago

Reviewers:
Roman

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Separate Dart backend specific logic from basic Unparser. That enables further optimisation for minification. For example, we can omit as clauses in dart2dart while still keeping them in basic unparser which should be as close to original program as possible. R=smok@google.com

Patch Set 1 #

Total comments: 1

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -35 lines)			Patch
M	lib/compiler/implementation/dart_backend/backend.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	lib/compiler/implementation/dart_backend/emitter.dart	View	1 chunk	+24 lines, -1 line	1 comment	Download
M	lib/compiler/implementation/tree/unparser.dart	View	3 chunks	+10 lines, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roman

lgtm https://chromiumcodereview.appspot.com/10905019/diff/1/lib/compiler/implementation/dart_backend/emitter.dart File lib/compiler/implementation/dart_backend/emitter.dart (right): https://chromiumcodereview.appspot.com/10905019/diff/1/lib/compiler/implementation/dart_backend/emitter.dart#newcode19 lib/compiler/implementation/dart_backend/emitter.dart:19: // TODO(smok): Remove ugly hack for library preferences. ...

8 years, 2 months ago (2012-10-01 14:10:34 UTC) #2

Is this issue obsolete?

Expand Messages | Collapse Messages