Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: lib/compiler/implementation/tree/unparser.dart

Issue 10905019: Separate Dart backend specific logic from basic Unparser. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/tree/unparser.dart
diff --git a/lib/compiler/implementation/tree/unparser.dart b/lib/compiler/implementation/tree/unparser.dart
index fe6a4935ff48e0803ebcb9ca0d85f2a0f394c300..4bd5723d68e5e0d6cb3aecff885cbdd57b4d8af5 100644
--- a/lib/compiler/implementation/tree/unparser.dart
+++ b/lib/compiler/implementation/tree/unparser.dart
@@ -2,20 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// Returns null if no need to rename a node.
-typedef String Renamer(Node node);
-
class Unparser implements Visitor {
- Renamer rename;
StringBuffer sb;
- Unparser() {
- // TODO(smok): Move this to initializer once dart2js stops complaining
- // about closures in initializers.
- rename = (Node node) => null;
- }
- Unparser.withRenamer(this.rename);
-
String unparse(Node node) {
sb = new StringBuffer();
visit(node);
@@ -35,14 +24,7 @@ class Unparser implements Visitor {
}
visit(Node node) {
- if (node === null) return;
- String renamed = rename(node);
- if (renamed !== null) {
- sb.add(renamed);
- } else {
- // Fallback.
- node.accept(this);
- }
+ if (node !== null) node.accept(this);
}
visitBlock(Block node) {
@@ -252,19 +234,15 @@ class Unparser implements Visitor {
}
unparseSendReceiver(Send node, [bool spacesNeeded=false]) {
- // TODO(smok): Remove ugly hack for library preferences.
- // Check that renamer does not want to omit receiver at all,
- // in that case we don't need spaces or dot.
- if (node.receiver !== null && rename(node.receiver) != '') {
- visit(node.receiver);
- CascadeReceiver asCascadeReceiver = node.receiver.asCascadeReceiver();
- if (asCascadeReceiver !== null) {
- add(asCascadeReceiver.cascadeOperator.value);
- } else if (node.selector.asOperator() === null) {
- sb.add('.');
- } else if (spacesNeeded) {
- sb.add(' ');
- }
+ if (node.receiver === null) return;
+ visit(node.receiver);
+ CascadeReceiver asCascadeReceiver = node.receiver.asCascadeReceiver();
+ if (asCascadeReceiver !== null) {
+ add(asCascadeReceiver.cascadeOperator.value);
+ } else if (node.selector.asOperator() === null) {
+ sb.add('.');
+ } else if (spacesNeeded) {
+ sb.add(' ');
}
}

Powered by Google App Engine
This is Rietveld 408576698