Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1283)

Unified Diff: src/trusted/validator_arm/actual_classes.h

Issue 10879090: ARM validator: continue with extra_load_store_instructions. (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Update with more tables. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/trusted/validator_arm/actual_classes.h
diff --git a/src/trusted/validator_arm/actual_classes.h b/src/trusted/validator_arm/actual_classes.h
index 1028c85a200f1a161ccff17909ef34cebc0f2ba9..94809665a4181f53db8151dd965e525167cbe4c0 100644
--- a/src/trusted/validator_arm/actual_classes.h
+++ b/src/trusted/validator_arm/actual_classes.h
@@ -452,10 +452,12 @@ class LoadBasedMemoryWithWriteBack : public LoadBasedMemory {
return indexing.IsPostIndexing(i) || writes.IsDefined(i);
}
- LoadBasedMemoryWithWriteBack() {}
virtual SafetyLevel safety(Instruction i) const;
virtual RegisterList defs(Instruction i) const;
+ protected:
+ LoadBasedMemoryWithWriteBack() {}
+
private:
NACL_DISALLOW_COPY_AND_ASSIGN(LoadBasedMemoryWithWriteBack);
};
@@ -550,10 +552,12 @@ class StoreBasedMemoryWithWriteBack : public BasedAddressUsingRn {
return indexing.IsPostIndexing(i) || writes.IsDefined(i);
}
- StoreBasedMemoryWithWriteBack() {}
virtual SafetyLevel safety(Instruction i) const;
virtual RegisterList defs(Instruction i) const;
+ protected:
+ StoreBasedMemoryWithWriteBack() {}
+
private:
NACL_DISALLOW_COPY_AND_ASSIGN(StoreBasedMemoryWithWriteBack);
};
@@ -703,6 +707,7 @@ class Roadblock : public OldClassDecoder {
class Breakpoint : public Roadblock {
public:
Breakpoint() {}
+ virtual SafetyLevel safety(Instruction i) const;
virtual bool is_literal_pool_head(Instruction i) const;
private:

Powered by Google App Engine
This is Rietveld 408576698