Const variables handled as final

Const variables handled as final

Committed: https://code.google.com/p/dart/source/detail?r=11170

[ahe, 2012-08-22 14:03:59]

+ngeoffray

[ahe, 2012-08-22 14:07:46]

LGTM!

https://chromiumcodereview.appspot.com/10879003/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/tree/nodes.dart (right):

https://chromiumcodereview.appspot.com/10879003/diff/2001/lib/compiler/implem...
lib/compiler/implementation/tree/nodes.dart:1141: * Returns [:true:] iff the
modifiers contain either [:final:] or [:const:],
The phrase "iff" is not standard vocabulary, so it is better to use "if and only
if", or rewrite the comment so you don't need to use "if and only if".

In this case, I wouldn't even include a documentation comment. It is obvious
what the method does.

[Johnni Winther, 2012-08-22 14:23:20]

https://chromiumcodereview.appspot.com/10879003/diff/2001/lib/compiler/implem...
File lib/compiler/implementation/tree/nodes.dart (right):

https://chromiumcodereview.appspot.com/10879003/diff/2001/lib/compiler/implem...
lib/compiler/implementation/tree/nodes.dart:1141: * Returns [:true:] iff the
modifiers contain either [:final:] or [:const:],
On 2012/08/22 14:07:46, ahe wrote:
> The phrase "iff" is not standard vocabulary, so it is better to use "if and
only
> if", or rewrite the comment so you don't need to use "if and only if".
> 
> In this case, I wouldn't even include a documentation comment. It is obvious
> what the method does.

The documentation was added to explain the semantic intention of the method,
i.e. explicitly+implicitly final as opposed to isFinal being syntactically
final.

[ngeoffray, 2012-08-22 14:24:23]

LGTM

https://chromiumcodereview.appspot.com/10879003/diff/2001/pkg/dartdoc/mirrors...
File pkg/dartdoc/mirrors/dart2js_mirror.dart (right):

https://chromiumcodereview.appspot.com/10879003/diff/2001/pkg/dartdoc/mirrors...
pkg/dartdoc/mirrors/dart2js_mirror.dart:1359: // TODO(johnniwinther): Should
this return true on const as well?
Why don't you do what you did in the compiler with isFinalOrConst? Is the API of
the mirror system specified so you need to change the specification first?

[Johnni Winther, 2012-08-22 16:13:16]

https://chromiumcodereview.appspot.com/10879003/diff/2001/pkg/dartdoc/mirrors...
File pkg/dartdoc/mirrors/dart2js_mirror.dart (right):

https://chromiumcodereview.appspot.com/10879003/diff/2001/pkg/dartdoc/mirrors...
pkg/dartdoc/mirrors/dart2js_mirror.dart:1359: // TODO(johnniwinther): Should
this return true on const as well?
On 2012/08/22 14:24:23, ngeoffray wrote:
> Why don't you do what you did in the compiler with isFinalOrConst? Is the API
of
> the mirror system specified so you need to change the specification first?

I need to coordinate with turnidge and gbracha.

[ahe, 2012-08-22 17:13:05]

This explains the build bot redness. All is well. I'll commit a status file
change.

https://chromiumcodereview.appspot.com/10879003/diff/6002/tests/co19/co19-dar...
File tests/co19/co19-dart2js.status (left):

https://chromiumcodereview.appspot.com/10879003/diff/6002/tests/co19/co19-dar...
tests/co19/co19-dart2js.status:145: Language/05_Variables/05_Variables_A05_t03:
Fail # Compile-time error: error: not a compile-time constant
Just as you thought you fixed this test, Mads broke it again :-)