Const variables handled as final

lib/compiler/implementation/tree/nodes.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface Visitor<R> {
   R visitBlock(Block node);
   R visitBreakStatement(BreakStatement node);
   R visitCascade(Cascade node);
   R visitCascadeReceiver(CascadeReceiver node);
   R visitCaseMatch(CaseMatch node);
@@ skipping 1119 matching lines @@
   visitChildren(Visitor visitor) => nodes.accept(visitor);
 
   bool isStatic() => (flags & FLAG_STATIC) != 0;
   bool isAbstract() => (flags & FLAG_ABSTRACT) != 0;
   bool isFinal() => (flags & FLAG_FINAL) != 0;
   bool isVar() => (flags & FLAG_VAR) != 0;
   bool isConst() => (flags & FLAG_CONST) != 0;
   bool isFactory() => (flags & FLAG_FACTORY) != 0;
   bool isExternal() => (flags & FLAG_EXTERNAL) != 0;
 
+  /**
+   * Returns [:true:] iff the modifiers contain either [:final:] or [:const:],

[ahe, 2012/08/22 14:07:46]

The phrase "iff" is not standard vocabulary, so it is better to use "if and only
if", or rewrite the comment so you don't need to use "if and only if".

In this case, I wouldn't even include a documentation comment. It is obvious
what the method does.

[Johnni Winther, 2012/08/22 14:23:20]

The documentation was added to explain the semantic intention of the method,
i.e. explicitly+implicitly final as opposed to isFinal being syntactically
final.

+   * that is, that the declaration is either explicitly or implicitly final.
+   */
+  bool isFinalOrConst() => isFinal() || isConst();
+
   String toString() {
     LinkBuilder<String> builder = new LinkBuilder<String>();
     if (isStatic()) builder.addLast('static');
     if (isAbstract()) builder.addLast('abstract');
     if (isFinal()) builder.addLast('final');
     if (isVar()) builder.addLast('var');
     if (isConst()) builder.addLast('const');
     if (isFactory()) builder.addLast('factory');
     if (isExternal()) builder.addLast('external');
     StringBuffer buffer = new StringBuffer();
@@ skipping 603 matching lines @@
  * argument).
  *
  * TODO(ahe): This method is controversial, the team needs to discuss
  * if top-level methods are acceptable and what naming conventions to
  * use.
  */
 initializerDo(Node node, f(Node node)) {
   SendSet send = node.asSendSet();
   if (send !== null) return f(send.arguments.head);
 }