Const variables handled as final

pkg/dartdoc/mirrors/dart2js_mirror.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #library('mirrors.dart2js');
 
 #import('../../../lib/compiler/compiler.dart', prefix: 'diagnostics');
 #import('../../../lib/compiler/implementation/elements/elements.dart');
 #import('../../../lib/compiler/implementation/apiimpl.dart', prefix: 'api');
 #import('../../../lib/compiler/implementation/scanner/scannerlib.dart');
@@ skipping 1338 matching lines @@
   bool get isConstructor() => false;
 
   bool get isField() => true;
 
   bool get isMethod() => false;
 
   bool get isPrivate() => _isPrivate(simpleName);
 
   bool get isStatic() => _variable.modifiers.isStatic();
 
+  // TODO(johnniwinther): Should this return true on const as well?

[ngeoffray, 2012/08/22 14:24:23]

Why don't you do what you did in the compiler with isFinalOrConst? Is the API of
the mirror system specified so you need to change the specification first?

[Johnni Winther, 2012/08/22 16:13:16]

I need to coordinate with turnidge and gbracha.

   bool get isFinal() => _variable.modifiers.isFinal();
 
   TypeMirror get type() => _convertTypeToTypeMirror(system,
       _variable.computeType(system.compiler),
       system.compiler.types.dynamicType);
 
   Location get location() {
     var script = _variable.getCompilationUnit().script;
     var node = _variable.variables.parseNode(_diagnosticListener);
     if (node !== null) {
       var span = system.compiler.spanFromNode(node, script.uri);
       return new Dart2JsLocation(script, span);
     } else {
       var span = system.compiler.spanFromElement(_variable);
       return new Dart2JsLocation(script, span);
     }
   }
 }