Issue 10878013: Don't show the zoom bubble when the settings menu is showing on views or GTK.

Issue 10878013: Don't show the zoom bubble when the settings menu is showing on views or GTK. (Closed)

Created:
8 years, 4 months ago by Dan Beam

Modified:
8 years, 4 months ago

Reviewers:
Kyle Horimoto, sky, Evan Stade

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't show the zoom bubble when the settings menu is showing on views or GTK. BUG=128816, 128070 R=estade@chromium.org,sky@chromium.org,khorimoto@chromium.org TEST=Hotdogs > +/- zoom (shouldn't show bubble nor jack focus) NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152957

Patch Set 3 : khorimoto@ review #

Total comments: 2

Patch Set 4 : s/settings/wrench/g #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -4 lines)			Patch
M	chrome/browser/ui/gtk/browser_toolbar_gtk.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_toolbar_gtk.cc	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/location_bar_view_gtk.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.cc	View	1 2 3	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/wrench_menu.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/wrench_menu.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

Dan Beam

oh sorry, I should mention: sky: chrome/browser/ui/views/* estade: chrome/browser/ui/gtk/* khorimoto: behavioral correctness/FYI

8 years, 4 months ago (2012-08-22 16:25:29 UTC) #2

Kyle Horimoto

LGTM https://chromiumcodereview.appspot.com/10878013/diff/2001/chrome/browser/ui/views/toolbar_view.h File chrome/browser/ui/views/toolbar_view.h (right): https://chromiumcodereview.appspot.com/10878013/diff/2001/chrome/browser/ui/views/toolbar_view.h#newcode162 chrome/browser/ui/views/toolbar_view.h:162: // Whether the wrench/hotdogs menus is currently showing. ...

8 years, 4 months ago (2012-08-22 17:31:13 UTC) #3

Dan Beam

https://chromiumcodereview.appspot.com/10878013/diff/2001/chrome/browser/ui/views/toolbar_view.h File chrome/browser/ui/views/toolbar_view.h (right): https://chromiumcodereview.appspot.com/10878013/diff/2001/chrome/browser/ui/views/toolbar_view.h#newcode162 chrome/browser/ui/views/toolbar_view.h:162: // Whether the wrench/hotdogs menus is currently showing. On ...

8 years, 4 months ago (2012-08-22 17:35:13 UTC) #4

sky

https://chromiumcodereview.appspot.com/10878013/diff/6001/chrome/browser/ui/views/toolbar_view.h File chrome/browser/ui/views/toolbar_view.h (right): https://chromiumcodereview.appspot.com/10878013/diff/6001/chrome/browser/ui/views/toolbar_view.h#newcode163 chrome/browser/ui/views/toolbar_view.h:163: bool IsSettingsMenuShowing() const; Since we use wrench menu every ...

8 years, 4 months ago (2012-08-22 19:36:29 UTC) #5

Dan Beam

8 years, 4 months ago (2012-08-22 23:10:37 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/10878013/9001

8 years, 4 months ago (2012-08-23 04:48:28 UTC) #10

Change committed as 152957

Expand Messages | Collapse Messages