Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10876089: Guard against more NULL pointers in WebstoreInstaller. (Closed)

Created:
8 years, 3 months ago by benjhayden
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Guard against more NULL pointers in WebstoreInstaller. BUG=126013, 124627 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154469

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M chrome/browser/extensions/webstore_installer.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 5 chunks +22 lines, -10 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
benjhayden
PTAL I was cleaning out my issue tracker when I noticed that this was still ...
8 years, 3 months ago (2012-08-27 19:32:34 UTC) #1
asargent_no_longer_on_chrome
LGTM
8 years, 3 months ago (2012-08-28 19:41:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10876089/1
8 years, 3 months ago (2012-08-29 17:16:31 UTC) #3
commit-bot: I haz the power
Try job failure for 10876089-1 (retry) on win_rel for steps "interactive_ui_tests, browser_tests". It's a second ...
8 years, 3 months ago (2012-08-29 20:11:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10876089/1
8 years, 3 months ago (2012-08-29 20:38:35 UTC) #5
commit-bot: I haz the power
Try job failure for 10876089-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 3 months ago (2012-08-29 23:53:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10876089/21001
8 years, 3 months ago (2012-08-30 15:27:46 UTC) #7
commit-bot: I haz the power
Try job failure for 10876089-21001 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 3 months ago (2012-08-30 16:55:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10876089/21001
8 years, 3 months ago (2012-08-30 17:04:27 UTC) #9
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
8 years, 3 months ago (2012-08-30 22:01:50 UTC) #10
benjhayden
https://memegen.googleplex.com/9183684
8 years, 3 months ago (2012-08-31 15:04:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benjhayden@chromium.org/10876089/21001
8 years, 3 months ago (2012-08-31 15:04:54 UTC) #12
commit-bot: I haz the power
8 years, 3 months ago (2012-08-31 18:27:45 UTC) #13 
Change committed as 154469

Powered by Google App Engine
This is Rietveld 408576698