Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/browser/extensions/webstore_installer.h

Issue 10876089: Guard against more NULL pointers in WebstoreInstaller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_installer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 // this managed its installation. This also removes the associated 151 // this managed its installation. This also removes the associated
152 // PendingInstall. 152 // PendingInstall.
153 void ReportSuccess(); 153 void ReportSuccess();
154 154
155 content::NotificationRegistrar registrar_; 155 content::NotificationRegistrar registrar_;
156 Profile* profile_; 156 Profile* profile_;
157 Delegate* delegate_; 157 Delegate* delegate_;
158 content::NavigationController* controller_; 158 content::NavigationController* controller_;
159 std::string id_; 159 std::string id_;
160 // The DownloadItem is owned by the DownloadManager and is valid from when 160 // The DownloadItem is owned by the DownloadManager and is valid from when
161 // OnDownloadStarted is called (with no error) until the DownloadItem 161 // OnDownloadStarted is called (with no error) until OnDownloadDestroyed().
162 // transitions to state REMOVING.
163 content::DownloadItem* download_item_; 162 content::DownloadItem* download_item_;
164 int flags_;
165 scoped_ptr<Approval> approval_; 163 scoped_ptr<Approval> approval_;
166 GURL download_url_; 164 GURL download_url_;
167 }; 165 };
168 166
169 } // namespace extensions 167 } // namespace extensions
170 168
171 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_H_ 169 #endif // CHROME_BROWSER_EXTENSIONS_WEBSTORE_INSTALLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698