Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: chrome/browser/extensions/webstore_installer.h

Issue 10876089: Guard against more NULL pointers in WebstoreInstaller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_installer.h
diff --git a/chrome/browser/extensions/webstore_installer.h b/chrome/browser/extensions/webstore_installer.h
index 2cc6a29f89d34d9d48038e303d7b82c2b863d98e..1555234db7aeda274638f67ebd3788731041d3f2 100644
--- a/chrome/browser/extensions/webstore_installer.h
+++ b/chrome/browser/extensions/webstore_installer.h
@@ -158,10 +158,8 @@ class WebstoreInstaller :public content::NotificationObserver,
content::NavigationController* controller_;
std::string id_;
// The DownloadItem is owned by the DownloadManager and is valid from when
- // OnDownloadStarted is called (with no error) until the DownloadItem
- // transitions to state REMOVING.
+ // OnDownloadStarted is called (with no error) until OnDownloadDestroyed().
content::DownloadItem* download_item_;
- int flags_;
scoped_ptr<Approval> approval_;
GURL download_url_;
};
« no previous file with comments | « no previous file | chrome/browser/extensions/webstore_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698