Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10873029: Migrate WebRequestRedirectByRegExAction to use RE2 and roll RE2 to revision 97:401ab4168e8e (Closed)

Created:
8 years, 4 months ago by battre
Modified:
8 years, 4 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

Migrate WebRequestRedirectByRegExAction to use RE2 and roll RE2 to revision 97:401ab4168e8e This is a relanding of https://chromiumcodereview.appspot.com/10826120/ after RE2 has been fixed upstream to contain no static initializers. TBR=yoz@chromium.org BUG=112155 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152992

Patch Set 1 #

Patch Set 2 : Merged with ToT #

Patch Set 3 : Merged with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+640 lines, -1270 lines) Patch
M chrome/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h View 4 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc View 1 5 chunks +14 lines, -28 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/re2/CONTRIBUTORS View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/re2/README.chromium View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/re2/patches/fix-implicit-conversion.patch View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/patches/re2-android.patch View 5 chunks +14 lines, -11 lines 0 comments Download
M third_party/re2/patches/re2-msvc9-chrome.patch View 20 chunks +128 lines, -1012 lines 0 comments Download
D third_party/re2/patches/remove-posix-option.patch View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/re2/patches/remove-valgrind-code.patch View 4 chunks +12 lines, -9 lines 0 comments Download
M third_party/re2/re2/compile.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/re2/re2/dfa.cc View 18 chunks +70 lines, -24 lines 0 comments Download
M third_party/re2/re2/parse.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M third_party/re2/re2/prefilter.cc View 12 chunks +55 lines, -11 lines 0 comments Download
M third_party/re2/re2/re2.h View 11 chunks +52 lines, -45 lines 0 comments Download
M third_party/re2/re2/re2.cc View 10 chunks +63 lines, -26 lines 0 comments Download
M third_party/re2/re2/regexp.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/re2/re2/regexp.cc View 4 chunks +28 lines, -17 lines 0 comments Download
M third_party/re2/re2/testing/filtered_re2_test.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/re2/re2/testing/parse_test.cc View 4 chunks +66 lines, -9 lines 0 comments Download
M third_party/re2/re2/testing/re2_arg_test.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/re2/re2/testing/re2_test.cc View 3 chunks +13 lines, -5 lines 0 comments Download
M third_party/re2/re2/testing/set_test.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/re2/util/logging.h View 2 chunks +10 lines, -3 lines 0 comments Download
M third_party/re2/util/mutex.h View 2 chunks +22 lines, -1 line 0 comments Download
M third_party/re2/util/sparse_array.h View 3 chunks +5 lines, -3 lines 0 comments Download
M third_party/re2/util/sparse_set.h View 4 chunks +6 lines, -4 lines 0 comments Download
M third_party/re2/util/util.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/re2/util/valgrind.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/re2/util/valgrind.cc View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
battre
Hi Yoz, I am going to TBR you because this is basically relanding the previous ...
8 years, 4 months ago (2012-08-23 14:27:24 UTC) #1
battre
8 years, 4 months ago (2012-08-23 14:28:01 UTC) #2 
Sorry, s/Yoz/Yoyo/

Best regards,
Dominic

On 2012/08/23 14:27:24, battre wrote:
> Hi Yoz,
> 
> I am going to TBR you because this is basically relanding the previous CL.
> 
> Best regards,
> Dominic

Powered by Google App Engine
This is Rietveld 408576698