Revert 152904 - Moving FaviconService to a ProfileKeyedService.

Revert 152904 - Moving FaviconService to a ProfileKeyedService.

BUG=112526
Review URL: https://chromiumcodereview.appspot.com/10828263

This seems to be causing win7 sync issues.

TBR=rlp@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152959

[Hironori Bono, 2012-08-23 11:28:42]

Greetings,

Apologies for reverting your change. It seems this change does not have
connection with the sync_integration_tests failure. Would it be possible to
un-revert this change?

Regards,

Hironori Bono

[ricow1, 2012-08-23 11:51:44]

On 2012/08/23 11:28:42, Hironori Bono wrote:
> Greetings,
> 
> Apologies for reverting your change. It seems this change does not have
> connection with the sync_integration_tests failure. Would it be possible to
> un-revert this change?
> 
> Regards,
> 
> Hironori Bono

I would like to let rlp recommit this, there was a small merge conflict, and in
addition drover messed up so the full revert is this + 152959

[rpetterson, 2012-08-23 17:50:55]

Hi,

I'm going to unrevert (sync & resubmit to the commit queue) my change, but
not sure what's going on with 152959. Do you need me to unrevert that after
my change is resubmitted?

Thanks,
Rachel

On Thu, Aug 23, 2012 at 4:51 AM, <ricow@google.com> wrote:

> On 2012/08/23 11:28:42, Hironori Bono wrote:
>
>> Greetings,
>>
>
>  Apologies for reverting your change. It seems this change does not have
>> connection with the sync_integration_tests failure. Would it be possible
>> to
>> un-revert this change?
>>
>
>  Regards,
>>
>
>  Hironori Bono
>>
>
> I would like to let rlp recommit this, there was a small merge conflict,
> and in
> addition drover messed up so the full revert is this + 152959
>
>
https://chromiumcodereview.**appspot.com/10873022/<https://chromiumcodereview...
>

[ricow1, 2012-08-23 18:11:04]

It is just that drover left I file out with an svn error, the left out
file got committed in 152959. If you just pull in our change instead
of the revert everything should be fine

Cheers,
Rico

On Thu, Aug 23, 2012 at 7:50 PM, Rachel Weinstein Petterson
<rlp@chromium.org> wrote:
> Hi,
>
> I'm going to unrevert (sync & resubmit to the commit queue) my change, but
> not sure what's going on with 152959. Do you need me to unrevert that after
> my change is resubmitted?
>
> Thanks,
> Rachel
>
>
> On Thu, Aug 23, 2012 at 4:51 AM, <ricow@google.com> wrote:
>>
>> On 2012/08/23 11:28:42, Hironori Bono wrote:
>>>
>>> Greetings,
>>
>>
>>> Apologies for reverting your change. It seems this change does not have
>>> connection with the sync_integration_tests failure. Would it be possible
>>> to
>>> un-revert this change?
>>
>>
>>> Regards,
>>
>>
>>> Hironori Bono
>>
>>
>> I would like to let rlp recommit this, there was a small merge conflict,
>> and in
>> addition drover messed up so the full revert is this + 152959
>>
>> https://chromiumcodereview.appspot.com/10873022/
>
>