Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc

Issue 10873022: Revert 152904 - Moving FaviconService to a ProfileKeyedService. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/favicon_source.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc
===================================================================
--- chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc (revision 152958)
+++ chrome/browser/ui/webui/ntp/android/bookmarks_handler.cc (working copy)
@@ -11,7 +11,6 @@
#include "chrome/browser/android/tab_android.h"
#include "chrome/browser/bookmarks/bookmark_model.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
-#include "chrome/browser/favicon/favicon_service_factory.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
@@ -351,10 +350,9 @@
if (!node)
return;
- FaviconService* favicon_service = FaviconServiceFactory::GetForProfile(
- profile, Profile::EXPLICIT_ACCESS);
+ FaviconService* favicon_service = profile->GetFaviconService(
+ Profile::EXPLICIT_ACCESS);
FaviconService::Handle handle = favicon_service->GetFaviconForURL(
- profile,
node->url(),
history::FAVICON | history::TOUCH_ICON,
&cancelable_consumer_,
@@ -379,8 +377,7 @@
Profile* profile = Profile::FromBrowserContext(
web_ui()->GetWebContents()->GetBrowserContext());
const BookmarkNode* node = cancelable_consumer_.GetClientData(
- FaviconServiceFactory::GetForProfile(profile, Profile::EXPLICIT_ACCESS),
- handle);
+ profile->GetFaviconService(Profile::EXPLICIT_ACCESS), handle);
TabAndroid* tab = TabAndroid::FromWebContents(
web_ui()->GetWebContents());
« no previous file with comments | « chrome/browser/ui/webui/favicon_source.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698