Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 10869047: Fix HistoryBackend::SetFavicons (Closed)

Created:
8 years, 4 months ago by pkotwicz
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Fix HistoryBackend::SetFavicons Bug=144253 Test=HistoryBackendTest.SetSameFaviconURLForTwoPages passes See bug for alternative repro steps. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153404

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -10 lines) Patch
M chrome/browser/history/history_backend.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history/history_backend.cc View 1 2 2 chunks +11 lines, -9 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 2 3 4 5 2 chunks +60 lines, -0 lines 0 comments Download
M chrome/browser/history/thumbnail_database.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
pkotwicz
8 years, 4 months ago (2012-08-24 20:30:26 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-24 21:19:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10869047/7001
8 years, 4 months ago (2012-08-24 21:21:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10869047/7003
8 years, 4 months ago (2012-08-25 01:20:17 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-08-26 12:03:14 UTC) #5
Change committed as 153404

Powered by Google App Engine
This is Rietveld 408576698