Fix HistoryBackend::SetFavicons

chrome/browser/history/history_backend_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
@@ skipping 105 matching lines @@
                           history::MostVisitedURLList data) {
     most_visited_list_.swap(data);
   }
 
   // Callback for QueryFiltered.
   void OnQueryFiltered(CancelableRequestProvider::Handle handle,
                        const history::FilteredURLList& data) {
     filtered_list_ = data;
   }
 
+  // Callback for UpdateFaviconMappingsAndFetch.
+  void OnFaviconData(FaviconService::Handle handle,
+                     history::FaviconData favicon_data) {
+  }
+
   const history::MostVisitedURLList& get_most_visited_list() const {
     return most_visited_list_;
   }
 
   const history::FilteredURLList& get_filtered_list() const {
     return filtered_list_;
   }
 
  protected:
   scoped_refptr<HistoryBackend> backend_;  // Will be NULL on init failure.
@@ skipping 1064 matching lines @@
   EXPECT_FALSE(backend_->AddOrUpdateIconMapping(
       url, icon_id, FAVICON, &replaced));
   EXPECT_EQ(0, replaced);
 
   std::vector<IconMapping> icon_mapping;
   EXPECT_TRUE(backend_->thumbnail_db_->GetIconMappingsForPageURL(
       url, &icon_mapping));
   EXPECT_EQ(1u, icon_mapping.size());
 }
 
+// Test that SetFavicon for a page which shares a FaviconID with another does
+// the right thing.
+TEST_F(HistoryBackendTest, SetSameFaviconURLForTwoPages) {
+  GURL favicon_url("http://www.google.com/favicon.ico");
+  GURL page_url1("http://www.google.com");
+  GURL page_url2("http://www.google.ca");
+
+  scoped_refptr<base::RefCountedMemory> bitmap_data(
+      new base::RefCountedBytes());
+  backend_->SetFavicon(page_url1, favicon_url, bitmap_data, FAVICON);
+
+  scoped_refptr<GetFaviconRequest> request(new GetFaviconRequest(
+      base::Bind(&HistoryBackendTest::OnFaviconData, base::Unretained(this))));
+  HistoryBackendCancelableRequest cancellable_request;
+  cancellable_request.MockScheduleOfRequest<GetFaviconRequest>(request);
+  backend_->UpdateFaviconMappingAndFetch(request, page_url2, favicon_url,
+                                         FAVICON);
+
+  // Check that the same FaviconID is mapped to both page URLs.
+  std::vector<IconMapping> icon_mappings1;
+  EXPECT_TRUE(backend_->thumbnail_db_->GetIconMappingsForPageURL(
+      page_url1, &icon_mappings1));
+  EXPECT_EQ(1u, icon_mappings1.size());
+  FaviconID favicon_id = icon_mappings1[0].icon_id;
+  EXPECT_NE(0, favicon_id);
+
+  std::vector<IconMapping> icon_mappings2;
+  EXPECT_TRUE(backend_->thumbnail_db_->GetIconMappingsForPageURL(
+      page_url2, &icon_mappings2));
+  EXPECT_EQ(1u, icon_mappings2.size());
+  EXPECT_EQ(favicon_id, icon_mappings2[0].icon_id);
+
+  // Update the bitmap data.
+  backend_->SetFavicon(page_url1, favicon_url, bitmap_data, FAVICON);
+
+  // |page_url1| and |page_url2| should still map to the same FaviconID
+  // and have valid bitmap data.
+  icon_mappings1.clear();
+  EXPECT_TRUE(backend_->thumbnail_db_->GetIconMappingsForPageURL(
+      page_url1, &icon_mappings1));
+  EXPECT_EQ(1u, icon_mappings1.size());
+  EXPECT_EQ(favicon_id, icon_mappings1[0].icon_id);
+
+  icon_mappings2.clear();
+  EXPECT_TRUE(backend_->thumbnail_db_->GetIconMappingsForPageURL(
+      page_url2, &icon_mappings2));
+  EXPECT_EQ(1u, icon_mappings2.size());
+  EXPECT_EQ(favicon_id, icon_mappings2[0].icon_id);
+
+  std::vector<FaviconBitmap> favicon_bitmaps;
+  EXPECT_TRUE(backend_->thumbnail_db_->GetFaviconBitmaps(favicon_id,
+                                                         &favicon_bitmaps));
+  EXPECT_EQ(1u, favicon_bitmaps.size());
+}
+
 TEST_F(HistoryBackendTest, GetFaviconForURL) {
   // This test will add a fav icon and touch icon for the same URL
   // and check the behaviour of backend's GetFaviconForURL implementation.
   const GURL url("http://www.google.com/");
   const GURL icon_url("http://www.google.com/icon");
   std::vector<unsigned char> data(blob1, blob1 + sizeof(blob1));
   scoped_refptr<base::RefCountedBytes> bytes(new base::RefCountedBytes(data));
   // Used for testing the icon data after getting from DB
   std::string blob_data(bytes->front(),
                         bytes->front() + bytes->size());
@@ skipping 387 matching lines @@
 
     backend_->DeleteURL(url);
     backend_->AddPageNoVisitForBookmark(url, string16());
     backend_->GetURL(url, &row);
     EXPECT_EQ(url, row.url());
     EXPECT_EQ(UTF8ToUTF16(url.spec()), row.title());
     EXPECT_EQ(0, row.visit_count());
 }
 
 }  // namespace history