chrome/browser/history/thumbnail_database.cc - Issue 10869047: Fix HistoryBackend::SetFavicons

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/thumbnail_database.cc

Issue 10869047: Fix HistoryBackend::SetFavicons (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/history/thumbnail_database.cc

diff --git a/chrome/browser/history/thumbnail_database.cc b/chrome/browser/history/thumbnail_database.cc

index d9462ada00ae4b5b1ce8bef8a5a18c56d1f07aeb..d35ee8ba9033b13d2668713f4b9e92c6e3a2622b 100644

--- a/chrome/browser/history/thumbnail_database.cc

+++ b/chrome/browser/history/thumbnail_database.cc

@@ -489,7 +489,7 @@ FaviconBitmapID ThumbnailDatabase::AddFaviconBitmap(

"INSERT INTO favicon_bitmaps (icon_id, image_data, last_updated, width, "

"height) VALUES (?, ?, ?, ?, ?)"));

statement.BindInt64(0, icon_id);

- if (icon_data->size()) {

+ if (icon_data.get() && icon_data->size()) {

statement.BindBlob(1, icon_data->front(),

static_cast<int>(icon_data->size()));

} else {

« no previous file with comments | « chrome/browser/history/history_backend_unittest.cc ('k') | no next file » | no next file with comments »