Move print to corelib.

Move print to corelib.

Depends on (https://chromiumcodereview.appspot.com/10867032/) to allow libraries to be imported with a prefix
in the VM.

BUG=

[Mads Ager (google), 2012-08-28 13:27:32]

I don't like the test changes that I had to do here to make all tests pass.
Suggestions are more than welcome.

[Anders Johnsen, 2012-08-28 13:53:10]

https://chromiumcodereview.appspot.com/10868043/diff/10001/corelib/src/implem...
File corelib/src/implementation/print.dart (right):

https://chromiumcodereview.appspot.com/10868043/diff/10001/corelib/src/implem...
corelib/src/implementation/print.dart:5: class Logger {
The name 'Logger' seams very generic. Can we pick something more specific to
this?

https://chromiumcodereview.appspot.com/10868043/diff/10001/runtime/vm/unit_te...
File runtime/vm/unit_test.h (right):

https://chromiumcodereview.appspot.com/10868043/diff/10001/runtime/vm/unit_te...
runtime/vm/unit_test.h:238: // Setup dummy builtin library for 'print'.
Just so I get this right, these test depends on 'print' to be defined?

[Mads Ager (google), 2012-08-28 13:57:29]

https://chromiumcodereview.appspot.com/10868043/diff/10001/corelib/src/implem...
File corelib/src/implementation/print.dart (right):

https://chromiumcodereview.appspot.com/10868043/diff/10001/corelib/src/implem...
corelib/src/implementation/print.dart:5: class Logger {
On 2012/08/28 13:53:10, ajohnsen wrote:
> The name 'Logger' seams very generic. Can we pick something more specific to
> this?

Sure. We can call it PrintImplementation? We can decide if we want to avoid all
these indirections through coreimpl once we get this in and have the unified
corelib.

https://chromiumcodereview.appspot.com/10868043/diff/10001/runtime/vm/unit_te...
File runtime/vm/unit_test.h (right):

https://chromiumcodereview.appspot.com/10868043/diff/10001/runtime/vm/unit_te...
runtime/vm/unit_test.h:238: // Setup dummy builtin library for 'print'.
On 2012/08/28 13:53:10, ajohnsen wrote:
> Just so I get this right, these test depends on 'print' to be defined?

Some of these tests use the CompileAll call that will compile everything in core
and coreimpl. In coreimpl we need to have 'builtin.print' for that to succeed.
Therefore, we need a builtin library that gets imported into coreimpl under a
prefix.

[Anders Johnsen, 2012-08-28 14:01:09]

LGTM, but I have a hard time seeing if we have other options then changing these
3 tests.

https://chromiumcodereview.appspot.com/10868043/diff/10001/corelib/src/implem...
File corelib/src/implementation/print.dart (right):

https://chromiumcodereview.appspot.com/10868043/diff/10001/corelib/src/implem...
corelib/src/implementation/print.dart:5: class Logger {
On 2012/08/28 13:57:29, Mads Ager wrote:
> On 2012/08/28 13:53:10, ajohnsen wrote:
> > The name 'Logger' seams very generic. Can we pick something more specific to
> > this?
> 
> Sure. We can call it PrintImplementation? We can decide if we want to avoid
all
> these indirections through coreimpl once we get this in and have the unified
> corelib.

PrintImplementation sounds good, I'm afraid we'll get conflicts in other user
code with the other name. Thank you.

https://chromiumcodereview.appspot.com/10868043/diff/10001/runtime/vm/unit_te...
File runtime/vm/unit_test.h (right):

https://chromiumcodereview.appspot.com/10868043/diff/10001/runtime/vm/unit_te...
runtime/vm/unit_test.h:238: // Setup dummy builtin library for 'print'.
On 2012/08/28 13:57:29, Mads Ager wrote:
> On 2012/08/28 13:53:10, ajohnsen wrote:
> > Just so I get this right, these test depends on 'print' to be defined?
> 
> Some of these tests use the CompileAll call that will compile everything in
core
> and coreimpl. In coreimpl we need to have 'builtin.print' for that to succeed.
> Therefore, we need a builtin library that gets imported into coreimpl under a
> prefix.

Thank you, I understand now.

[Mads Ager (google), 2012-08-28 14:07:45]

Thanks Anders. I will wait for Ivan's comments before putting this back.

[Ivan Posva, 2012-08-29 06:21:15]

https://chromiumcodereview.appspot.com/10868043/diff/10001/corelib/src/implem...
File corelib/src/implementation/print.dart (right):

https://chromiumcodereview.appspot.com/10868043/diff/10001/corelib/src/implem...
corelib/src/implementation/print.dart:5: class Logger {
On 2012/08/28 14:01:09, ajohnsen wrote:
> On 2012/08/28 13:57:29, Mads Ager wrote:
> > On 2012/08/28 13:53:10, ajohnsen wrote:
> > > The name 'Logger' seams very generic. Can we pick something more specific
to
> > > this?
> > 
> > Sure. We can call it PrintImplementation? We can decide if we want to avoid
> all
> > these indirections through coreimpl once we get this in and have the unified
> > corelib.
> 
> PrintImplementation sounds good, I'm afraid we'll get conflicts in other user
> code with the other name. Thank you.

The conflicts with other user code would only happen with libraries importing
coreimpl explicitly.

[Anders Johnsen, 2012-08-29 06:54:07]

https://chromiumcodereview.appspot.com/10868043/diff/10001/corelib/src/implem...
File corelib/src/implementation/print.dart (right):

https://chromiumcodereview.appspot.com/10868043/diff/10001/corelib/src/implem...
corelib/src/implementation/print.dart:5: class Logger {
On 2012/08/29 06:21:16, Ivan Posva wrote:
> On 2012/08/28 14:01:09, ajohnsen wrote:
> > On 2012/08/28 13:57:29, Mads Ager wrote:
> > > On 2012/08/28 13:53:10, ajohnsen wrote:
> > > > The name 'Logger' seams very generic. Can we pick something more
specific
> to
> > > > this?
> > > 
> > > Sure. We can call it PrintImplementation? We can decide if we want to
avoid
> > all
> > > these indirections through coreimpl once we get this in and have the
unified
> > > corelib.
> > 
> > PrintImplementation sounds good, I'm afraid we'll get conflicts in other
user
> > code with the other name. Thank you.
> 
> The conflicts with other user code would only happen with libraries importing
> coreimpl explicitly.

True, but I actually have code where i have my own Logger class, and where I
import coreimpl to get SplayTreeMap, so it's not an unlikely scenario.