corelib/src/implementation/print.dart - Issue 10868043: Move print to corelib.

Side by Side Diff: corelib/src/implementation/print.dart

Issue 10868043: Move print to corelib. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Make it pass all tests. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 int test3a() {	5 class Logger {
	Anders Johnsen 2012/08/28 13:53:10 The name 'Logger' seams very generic. Can we pick The name 'Logger' seams very generic. Can we pick something more specific to this? Mads Ager (google) 2012/08/28 13:57:29 Sure. We can call it PrintImplementation? We can d Show quoted text On 2012/08/28 13:53:10, ajohnsen wrote: > The name 'Logger' seams very generic. Can we pick something more specific to > this? Sure. We can call it PrintImplementation? We can decide if we want to avoid all these indirections through coreimpl once we get this in and have the unified corelib. Anders Johnsen 2012/08/28 14:01:09 PrintImplementation sounds good, I'm afraid we'll Show quoted text On 2012/08/28 13:57:29, Mads Ager wrote: > On 2012/08/28 13:53:10, ajohnsen wrote: > > The name 'Logger' seams very generic. Can we pick something more specific to > > this? > > Sure. We can call it PrintImplementation? We can decide if we want to avoid all > these indirections through coreimpl once we get this in and have the unified > corelib. PrintImplementation sounds good, I'm afraid we'll get conflicts in other user code with the other name. Thank you. Ivan Posva 2012/08/29 06:21:16 The conflicts with other user code would only happ Show quoted text On 2012/08/28 14:01:09, ajohnsen wrote: > On 2012/08/28 13:57:29, Mads Ager wrote: > > On 2012/08/28 13:53:10, ajohnsen wrote: > > > The name 'Logger' seams very generic. Can we pick something more specific to > > > this? > > > > Sure. We can call it PrintImplementation? We can decide if we want to avoid > all > > these indirections through coreimpl once we get this in and have the unified > > corelib. > > PrintImplementation sounds good, I'm afraid we'll get conflicts in other user > code with the other name. Thank you. The conflicts with other user code would only happen with libraries importing coreimpl explicitly. Anders Johnsen 2012/08/29 06:54:07 True, but I actually have code where i have my own Show quoted text On 2012/08/29 06:21:16, Ivan Posva wrote: > On 2012/08/28 14:01:09, ajohnsen wrote: > > On 2012/08/28 13:57:29, Mads Ager wrote: > > > On 2012/08/28 13:53:10, ajohnsen wrote: > > > > The name 'Logger' seams very generic. Can we pick something more specific > to > > > > this? > > > > > > Sure. We can call it PrintImplementation? We can decide if we want to avoid > > all > > > these indirections through coreimpl once we get this in and have the unified > > > corelib. > > > > PrintImplementation sounds good, I'm afraid we'll get conflicts in other user > > code with the other name. Thank you. > > The conflicts with other user code would only happen with libraries importing > coreimpl explicitly. True, but I actually have code where i have my own Logger class, and where I import coreimpl to get SplayTreeMap, so it's not an unlikely scenario.
6 return 3;	6 external static void print(Object obj);

7 }	7 }

OLD	NEW

« no previous file with comments | « corelib/src/implementation/corelib_impl_sources.gypi ('k') | corelib/src/print.dart » ('j') | runtime/vm/unit_test.h » ('J')