Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: runtime/vm/custom_isolate_test.cc

Issue 10868043: Move print to corelib. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make it pass all tests. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/custom_isolate_test.cc
diff --git a/runtime/vm/custom_isolate_test.cc b/runtime/vm/custom_isolate_test.cc
index d767b3084cdd39d7b107f4a9b19fee9021268487..bac546aacd38e0913b717a499aabf978b5982966 100644
--- a/runtime/vm/custom_isolate_test.cc
+++ b/runtime/vm/custom_isolate_test.cc
@@ -1,4 +1,4 @@
-// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
@@ -167,6 +167,7 @@ void StartEvent::Process() {
OS::Print(">> StartEvent with isolate(%p)--\n", isolate());
Dart_EnterIsolate(isolate());
Dart_EnterScope();
+
Dart_Handle result;
// Reload all the test classes here.
@@ -282,6 +283,24 @@ static void CustomIsolateImpl_start(Dart_NativeArguments args) {
// Create a new Dart_Isolate.
Dart_Isolate new_isolate = TestCase::CreateTestIsolate();
EXPECT(new_isolate != NULL);
+
+ {
+ // Setup dummy builtin library for 'print'.
+ Dart_EnterScope();
+ const char* builtin_source =
+ "#library('dart:builtin');\n"
+ "void print(Object o) { }";
+ Dart_Handle coreimpl = Dart_LookupLibrary(Dart_NewString("dart:coreimpl"));
+ EXPECT_VALID(coreimpl);
+ Dart_Handle builtin = Dart_LoadLibrary(Dart_NewString("dart:builtin"),
+ Dart_NewString(builtin_source));
+ EXPECT_VALID(builtin);
+ Dart_Handle imported =
+ Dart_LibraryImportLibrary(coreimpl, builtin, Dart_NewString("builtin"));
+ EXPECT_VALID(imported);
+ Dart_ExitScope();
+ }
+
Dart_SetMessageNotifyCallback(&NotifyMessage);
Dart_Port new_port = Dart_GetMainPortId();

Powered by Google App Engine
This is Rietveld 408576698