Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10860082: Remove overly agressive ASSERTs on output GL parameters. (Closed)

Created:
8 years, 4 months ago by greggman
Modified:
8 years, 4 months ago
CC:
chromium-reviews, apatrick_chromium
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Remove overly agressive ASSERTs on output GL parameters. BUG=144022 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152900

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -135 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 2 chunks +7 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 69 chunks +123 lines, -126 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 3 chunks +7 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h View 5 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
greggman
Sorry, apparently the build script wasn't run on some previous CL and so a few ...
8 years, 4 months ago (2012-08-21 23:14:16 UTC) #1
greggman
Oh yea, Hey John, PTAL. Thanks
8 years, 4 months ago (2012-08-21 23:14:46 UTC) #2
apatrick_chromium
lgtm
8 years, 4 months ago (2012-08-21 23:17:02 UTC) #3
jbauman
lgtm
8 years, 4 months ago (2012-08-22 00:10:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10860082/1
8 years, 4 months ago (2012-08-22 01:02:33 UTC) #5
commit-bot: I haz the power
Try job failure for 10860082-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-22 02:50:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10860082/1
8 years, 4 months ago (2012-08-22 05:55:57 UTC) #7
commit-bot: I haz the power
Try job failure for 10860082-1 (retry) on linux_rel for step "interactive_ui_tests". It's a second try, ...
8 years, 4 months ago (2012-08-22 07:34:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10860082/1
8 years, 4 months ago (2012-08-22 15:14:54 UTC) #9
commit-bot: I haz the power
Try job failure for 10860082-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-22 16:42:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10860082/1
8 years, 4 months ago (2012-08-22 17:18:22 UTC) #11
commit-bot: I haz the power
8 years, 4 months ago (2012-08-22 19:23:20 UTC) #12 
Try job failure for 10860082-1 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698