Issue 10860010: Fix uint8_t/unit32_t mix, always use wordsize access

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10860010: Fix uint8_t/unit32_t mix, always use wordsize access (Closed)

Created:
8 years, 4 months ago by khim

Modified:
8 years, 4 months ago

Reviewers:
halyavin

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

More Reviews

Description

Fix uint8_t/unit32_t mix, always use wordsize access BUG=http://code.google.com/p/nativeclient/issues/detail?id=2597 TEST=trybots (no change in functionality) Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9501

Patch Set 1 #

Total comments: 5

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -30 lines)			Patch
M	src/trusted/validator_ragel/gen/validator_x86_32.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/trusted/validator_ragel/gen/validator_x86_64.c	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/trusted/validator_ragel/unreviewed/validator_internal.h	View	1	6 chunks	+32 lines, -22 lines	0 comments	Download
M	src/trusted/validator_ragel/unreviewed/validator_x86_32.rl	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/trusted/validator_ragel/unreviewed/validator_x86_64.rl	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

halyavin

8 years, 4 months ago (2012-08-17 15:22:37 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10860010/diff/1/src/trusted/validator_...
File src/trusted/validator_ragel/unreviewed/validator_internal.h (right):

https://chromiumcodereview.appspot.com/10860010/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator_internal.h:147: size_t
byte_count = (indexes + NACL_HOST_WORDSIZE - 1) / NACL_HOST_WORDSIZE;
byte_count->word_count

https://chromiumcodereview.appspot.com/10860010/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator_internal.h:148: bitmap_word
*bitmap = malloc(byte_count/(NACL_HOST_WORDSIZE/8));
*sizeof(bitmap_word)

https://chromiumcodereview.appspot.com/10860010/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator_internal.h:157: (1 << (index %
NACL_HOST_WORDSIZE))) != 0;
((bitmap_word)1)

https://chromiumcodereview.appspot.com/10860010/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator_internal.h:161: bitmap[index /
NACL_HOST_WORDSIZE] |= 1 << (index % NACL_HOST_WORDSIZE);
same

https://chromiumcodereview.appspot.com/10860010/diff/1/src/trusted/validator_...
src/trusted/validator_ragel/unreviewed/validator_internal.h:165: bitmap[index /
NACL_HOST_WORDSIZE] &= ~(1 << (index % NACL_HOST_WORDSIZE));
same

Expand Messages | Collapse Messages