Fix uint8_t/unit32_t mix, always use wordsize access

src/trusted/validator_ragel/unreviewed/validator_internal.h

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /*
  * This file contains common parts of x86-32 and x86-64 insternals (inline
  * functions and defines).
  */
@@ skipping 119 matching lines @@
 #define SET_BRANCH_TAKEN(S)
 #define SET_BRANCH_NOT_TAKEN(S)
 #define SET_MODRM_SCALE(S)
 #define SET_DISP_TYPE(T)
 #define SET_DISP_PTR(P)
 #define SET_IMM_TYPE(T)
 #define SET_IMM_PTR(P)
 #define SET_IMM2_TYPE(T)
 #define SET_IMM2_PTR(P)
 
-static const int kBitsPerByte = 8;
+#define BITMAP_WORD_NAME BITMAP_WORD_NAME1(NACL_HOST_WORDSIZE)
+#define BITMAP_WORD_NAME1(size) BITMAP_WORD_NAME2(size)
+#define BITMAP_WORD_NAME2(size) uint##size##_t
 
-static INLINE uint8_t *BitmapAllocate(size_t indexes) {
-  size_t byte_count = (indexes + kBitsPerByte - 1) / kBitsPerByte;
-  uint8_t *bitmap = malloc(byte_count);
+typedef BITMAP_WORD_NAME bitmap_word;
+
+static INLINE bitmap_word *BitmapAllocate(size_t indexes) {
+  size_t byte_count = (indexes + NACL_HOST_WORDSIZE - 1) / NACL_HOST_WORDSIZE;

[halyavin, 2012/08/17 15:22:37]

byte_count->word_count

+  bitmap_word *bitmap = malloc(byte_count/(NACL_HOST_WORDSIZE/8));

[halyavin, 2012/08/17 15:22:37]

*sizeof(bitmap_word)

   if (bitmap != NULL) {
     memset(bitmap, 0, byte_count);
   }
   return bitmap;
 }
 
-static FORCEINLINE int BitmapIsBitSet(uint8_t *bitmap, size_t index) {
-  return (bitmap[index / kBitsPerByte] & (1 << (index % kBitsPerByte))) != 0;
+static FORCEINLINE int BitmapIsBitSet(bitmap_word *bitmap, size_t index) {
+  return (bitmap[index / NACL_HOST_WORDSIZE] &
+          (1 << (index % NACL_HOST_WORDSIZE))) != 0;

[halyavin, 2012/08/17 15:22:37]

((bitmap_word)1)

 }
 
-static FORCEINLINE void BitmapSetBit(uint8_t *bitmap, size_t index) {
-  bitmap[index / kBitsPerByte] |= 1 << (index % kBitsPerByte);
+static FORCEINLINE void BitmapSetBit(bitmap_word *bitmap, size_t index) {
+  bitmap[index / NACL_HOST_WORDSIZE] |= 1 << (index % NACL_HOST_WORDSIZE);

[halyavin, 2012/08/17 15:22:37]

same

 }
 
-static FORCEINLINE void BitmapClearBit(uint8_t *bitmap, size_t index) {
-  bitmap[index / kBitsPerByte] &= ~(1 << (index % kBitsPerByte));
+static FORCEINLINE void BitmapClearBit(bitmap_word *bitmap, size_t index) {
+  bitmap[index / NACL_HOST_WORDSIZE] &= ~(1 << (index % NACL_HOST_WORDSIZE));

[halyavin, 2012/08/17 15:22:37]

same

 }
 
 /* Mark the destination of a jump instruction and make an early validity check:
  * to jump outside given code region, the target address must be aligned.
  *
  * Returns TRUE iff the jump passes the early validity check.
  */
 static FORCEINLINE int MarkJumpTarget(size_t jump_dest,
-                                      uint8_t *jump_dests,
+                                      bitmap_word *jump_dests,
                                       size_t size) {
   if ((jump_dest & kBundleMask) == 0) {
     return TRUE;
   }
   if (jump_dest >= size) {
     return FALSE;
   }
   BitmapSetBit(jump_dests, jump_dest);
   return TRUE;
 }
 
 
 static INLINE Bool ProcessInvalidJumpTargets(
     const uint8_t *data,
     size_t size,
-    uint8_t *valid_targets,
-    uint8_t *jump_dests,
+    bitmap_word *valid_targets,
+    bitmap_word *jump_dests,
     validation_callback_func user_callback,
     void *callback_data) {
+  size_t elements = (size + NACL_HOST_WORDSIZE / 8 - 1) &
+                    ~(NACL_HOST_WORDSIZE / 8 - 1);
   size_t i;
 
-  assert(size % 32 == 0);
-
-  for (i = 0; i < size / 32; i++) {
-    uint32_t jump_dest_mask = ((uint32_t *) jump_dests)[i];
-    uint32_t valid_target_mask = ((uint32_t *) valid_targets)[i];
+  for (i = 0; i < elements ; i++) {
+    bitmap_word jump_dest_mask = jump_dests[i];
+    bitmap_word valid_target_mask = valid_targets[i];
     if ((jump_dest_mask & ~valid_target_mask) != 0) {
       // TODO(shcherbina): report address precisely, not just 32-byte block
       // TODO(khim): report all errors found, not just the first one
-      return user_callback(data + i * 32, data + i * 32, BAD_JUMP_TARGET,
+      return user_callback(data + i * NACL_HOST_WORDSIZE,
+                           data + i * NACL_HOST_WORDSIZE, BAD_JUMP_TARGET,
                            callback_data);
     }
   }
 
   return TRUE;
 }
 
 
 /*
  * Process rel8_operand.  Note: rip points to the beginning of the next
  * instruction here and x86 encoding guarantees rel8 field is the last one
  * in a current instruction.
  */
 static FORCEINLINE void rel8_operand(const uint8_t *rip,
                                      const uint8_t* codeblock_start,
-                                     uint8_t *jump_dests, size_t jumpdests_size,
+                                     bitmap_word *jump_dests,
+                                     size_t jumpdests_size,
                                      uint32_t *instruction_info_collected) {
   int8_t offset = (uint8_t) (rip[-1]);
   size_t jump_dest = offset + (rip - codeblock_start);
 
   if (!MarkJumpTarget(jump_dest, jump_dests, jumpdests_size)) {
     *instruction_info_collected |= DIRECT_JUMP_OUT_OF_RANGE;
   }
 }
 
 /*
  * Process rel32_operand.  Note: rip points to the beginning of the next
  * instruction here and x86 encoding guarantees rel32 field is the last one
  * in a current instruction.
  */
 static FORCEINLINE void rel32_operand(const uint8_t *rip,
                                       const uint8_t* codeblock_start,
-                                      uint8_t *jump_dests,
+                                      bitmap_word *jump_dests,
                                       size_t jumpdests_size,
                                       uint32_t *instruction_info_collected) {
   int32_t offset = (rip[-4] + 256U * (rip[-3] + 256U * (
                                        rip[-2] + 256U * ((uint32_t) rip[-1]))));
   size_t jump_dest = offset + (rip - codeblock_start);
 
   if (!MarkJumpTarget(jump_dest, jump_dests, jumpdests_size)) {
     *instruction_info_collected |= DIRECT_JUMP_OUT_OF_RANGE;
   }
 }
 
 static INLINE void check_access(ptrdiff_t instruction_start,
                                 enum register_name base,
                                 enum register_name index,
                                 uint8_t restricted_register,
-                                uint8_t *valid_targets,
+                                bitmap_word *valid_targets,
                                 uint32_t *instruction_info_collected) {
   if ((base == REG_RIP) || (base == REG_R15) ||
       (base == REG_RSP) || (base == REG_RBP)) {
     if (index == restricted_register) {
       BitmapClearBit(valid_targets, instruction_start);
     } else if ((index != NO_REG) && (index != REG_RIZ)) {
       *instruction_info_collected |= UNRESTRICTED_INDEX_REGISTER;
     }
   } else {
     *instruction_info_collected |= FORBIDDEN_BASE_REGISTER;
@@ skipping 81 matching lines @@
       *instruction_info_collected |= RESTRICTED_RBP_UNPROCESSED;
     }
   /* Take 2 bits of operand type from operand_states as *restricted_register,
    * make sure operand_states denotes a register (12th bit == 0).  */
   } else if ((operand_states & 0x7000) == (OperandSandboxRestricted << 13)) {
     *restricted_register = (operand_states & 0x0f00) >> 8;
   }
 }
 
 #endif  /* NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_RAGEL_VALIDATOR_INTERNAL_H_ */