Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(45)

Issue 10857077: Revert 125941 - Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization… (Closed)

Created:
8 years, 1 month ago by Mark Larson
Modified:
8 years, 1 month ago
Reviewers:
Mark Larson
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Revert 125941 - Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed https://bugs.webkit.org/show_bug.cgi?id=94232 Reviewed by James Robinson. Source/WebCore: CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be called when there is no renderer present or it will crash. Chromium bug: crbug.com/125482 Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList): (WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList): Source/WebKit/chromium: Also updated the finishAllRenderingAfterContextLost to properly fail renderer initialization. * tests/CCLayerTreeHostImplTest.cpp: TBR=danakj@chromium.org Review URL: https://chromiumcodereview.appspot.com/10829399 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125970

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -26 lines) Patch
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp View 3 chunks +5 lines, -23 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Mark Larson
8 years, 1 month ago (2012-08-18 22:54:35 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698