Issue 10857077: Revert 125941 - Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10857077: Revert 125941 - Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization… (Closed)

Created:
8 years, 4 months ago by Mark Larson

Modified:
8 years, 4 months ago

Reviewers:
Mark Larson

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/

Visibility:
Public.

More Reviews

Description

Revert 125941 - Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed https://bugs.webkit.org/show_bug.cgi?id=94232 Reviewed by James Robinson. Source/WebCore: CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be called when there is no renderer present or it will crash. Chromium bug: crbug.com/125482 Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList): (WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList): Source/WebKit/chromium: Also updated the finishAllRenderingAfterContextLost to properly fail renderer initialization. * tests/CCLayerTreeHostImplTest.cpp: TBR=danakj@chromium.org Review URL: https://chromiumcodereview.appspot.com/10829399 TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125970

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -26 lines)			Patch
	M	Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp	View		2 chunks	+0 lines, -3 lines	0 comments	Download
	M	Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp	View		3 chunks	+5 lines, -23 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages