Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 10829399: Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
danakj, mal
CC:
chromium-reviews, kerz_chromium
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Merge 125799 - [chromium] Impl scrolling crashes when the renderer's initialization failed https://bugs.webkit.org/show_bug.cgi?id=94232 Reviewed by James Robinson. Source/WebCore: CCLayerTreeHostImpl::calculateRenderSurfaceLayerList should not be called when there is no renderer present or it will crash. Chromium bug: crbug.com/125482 Tests: CCLayerTreeHostImplTest.scrollWithoutRenderer * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp: (WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList): (WebCore::CCLayerTreeHostImpl::ensureRenderSurfaceLayerList): Source/WebKit/chromium: Also updated the finishAllRenderingAfterContextLost to properly fail renderer initialization. * tests/CCLayerTreeHostImplTest.cpp: TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125941

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp View 3 chunks +23 lines, -5 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
danakj
8 years, 1 month ago (2012-08-17 22:03:55 UTC) #1
mal
https://chromiumcodereview.appspot.com/10829399/diff/1/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp File Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp (right): https://chromiumcodereview.appspot.com/10829399/diff/1/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp#newcode287 Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:287: m_hostImpl->initializeLayerRenderer(FakeWebCompositorOutputSurface::create(adoptPtr(new FakeWebGraphicsContext3DMakeCurrentFails)), UnthrottledUploader); third_party/WebKit/Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp: In member function ‘virtual void<unnamed>::CCLayerTreeHostImplTest_scrollWithoutRenderer_Test::TestBody()’: ...
8 years, 1 month ago (2012-08-18 22:45:09 UTC) #2
mal
I was able to recall my dusty olde webkit credentials and reverted this on the ...
8 years, 1 month ago (2012-08-18 22:57:51 UTC) #3
danakj
8 years, 1 month ago (2012-08-20 15:01:24 UTC) #4
On 2012/08/18 22:57:51, mal wrote:
> I was able to recall my dusty olde webkit credentials and reverted this on the
> branch:
> 
> http://trac.webkit.org/changeset/125970

Ah, okay! Sorry for that, I'll re-merge without the test changes.

Powered by Google App Engine
This is Rietveld 408576698