Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument (Closed)

Created:
8 years, 4 months ago by shalev
Modified:
8 years, 3 months ago
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, jam, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., pam+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Refactoring: ProtocolHandler::MaybeCreateJob and other functions take NetworkDelegate as argument This change goes a long way to prepare for removing NetworkDelegate from URLRequestContext. TBR=sky@chromium.org, michaeln@chromium.org, benjhayden@chromium.org, brettw@chromium.org, ben@chromium.org, davemoore@chromium.org, zelidrag@chromium.org, mnissler@chromium.org, thestig@chromium.org, asargent@chromium.org, jhawkins@chromium.org, bulach@chromium.org BUG=crbug.com/142945 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153133

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed Chromeos #

Patch Set 3 : NetworkDelegate fixed almost everywhere #

Total comments: 24

Patch Set 4 : Fixed merge conflict #

Patch Set 5 : Fixed net_unittests bug #

Patch Set 6 : Fixed tryjob compile errors #

Patch Set 7 : Removed includes #

Patch Set 8 : chromeos fix #

Patch Set 9 : More chromeos fixes #

Patch Set 10 : Merged with about: stuff #

Patch Set 11 : Merged #

Patch Set 12 : Latest merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+931 lines, -559 lines) Patch
M chrome/browser/android/android_protocol_adapter.cc View 1 2 3 4 5 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/android/android_stream_reader_url_request_job.h View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/android/android_stream_reader_url_request_job.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/url_request_automation_job.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/automation/url_request_automation_job.cc View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 6 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/gdata/gdata_protocol_handler.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/gdata/gdata_protocol_handler.cc View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.h View 1 2 3 4 5 1 chunk +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.cc View 1 2 3 4 5 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/registration_screen.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/registration_screen.cc View 1 2 3 4 5 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/component_updater/component_updater_interceptor.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_interceptor.cc View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.cc View 1 2 3 4 5 5 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_unittest.cc View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/autoupdate_interceptor.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/autoupdate_interceptor.cc View 1 2 4 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 1 2 3 8 chunks +30 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_resource_protocols.cc View 1 2 3 3 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/extensions/user_script_listener_unittest.cc View 1 2 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/net/about_protocol_handler.h View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/about_protocol_handler.cc View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/net/connect_interceptor.h View 1 2 3 4 5 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/net/connect_interceptor.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/net/url_request_mock_link_doctor_job.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/net/url_request_mock_link_doctor_job.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/policy/device_management_service_browsertest.cc View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud_interative_uitest.cc View 1 2 3 chunks +16 lines, -7 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 2 3 4 5 6 7 8 9 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 1 2 3 6 chunks +13 lines, -8 lines 0 comments Download
M chrome_frame/test/net/test_automation_provider.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M chrome_frame/test/net/test_automation_provider.cc View 1 2 3 4 5 2 chunks +6 lines, -3 lines 0 comments Download
M content/browser/histogram_internals_request_job.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/histogram_internals_request_job.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/net/view_blob_internals_job_factory.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/net/view_blob_internals_job_factory.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/net/view_http_cache_job_factory.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/net/view_http_cache_job_factory.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/resource_dispatcher_host_unittest.cc View 1 2 4 chunks +43 lines, -25 lines 0 comments Download
M content/browser/resource_context_impl.cc View 1 2 3 4 5 2 chunks +12 lines, -8 lines 0 comments Download
M content/browser/tcmalloc_internals_request_job.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/tcmalloc_internals_request_job.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M content/test/net/url_request_abort_on_end_job.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/test/net/url_request_abort_on_end_job.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M content/test/net/url_request_failed_job.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M content/test/net/url_request_failed_job.cc View 1 2 3 chunks +7 lines, -4 lines 0 comments Download
M content/test/net/url_request_mock_http_job.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/test/net/url_request_mock_http_job.cc View 1 2 3 3 chunks +10 lines, -8 lines 0 comments Download
M content/test/net/url_request_slow_download_job.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/test/net/url_request_slow_download_job.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M content/test/net/url_request_slow_http_job.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/test/net/url_request_slow_http_job.cc View 1 2 2 chunks +10 lines, -6 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 2 3 4 5 1 chunk +8 lines, -6 lines 0 comments Download
M net/url_request/data_protocol_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/data_protocol_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/file_protocol_handler.h View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M net/url_request/file_protocol_handler.cc View 1 2 3 4 5 6 2 chunks +9 lines, -10 lines 0 comments Download
M net/url_request/ftp_protocol_handler.h View 1 chunk +3 lines, -4 lines 0 comments Download
M net/url_request/ftp_protocol_handler.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M net/url_request/url_request.h View 1 2 3 4 4 chunks +9 lines, -4 lines 0 comments Download
M net/url_request/url_request.cc View 1 2 3 4 6 chunks +15 lines, -9 lines 0 comments Download
M net/url_request/url_request_about_job.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_about_job.cc View 1 2 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M net/url_request/url_request_data_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_data_job.cc View 1 2 3 4 5 6 1 chunk +5 lines, -3 lines 0 comments Download
M net/url_request/url_request_error_job.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/url_request/url_request_error_job.cc View 1 2 3 4 5 6 1 chunk +3 lines, -4 lines 0 comments Download
M net/url_request/url_request_file_dir_job.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/url_request/url_request_file_dir_job.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_file_job.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_file_job.cc View 1 2 3 4 5 6 4 chunks +8 lines, -12 lines 0 comments Download
M net/url_request/url_request_filter.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_filter.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M net/url_request/url_request_filter_unittest.cc View 1 2 9 chunks +20 lines, -12 lines 0 comments Download
M net/url_request/url_request_ftp_job.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_ftp_job.cc View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M net/url_request/url_request_ftp_job_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/url_request/url_request_http_job.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 3 1 chunk +8 lines, -5 lines 0 comments Download
M net/url_request/url_request_job_factory.h View 1 2 3 4 5 6 chunks +20 lines, -10 lines 0 comments Download
M net/url_request/url_request_job_factory.cc View 1 2 3 4 5 3 chunks +10 lines, -8 lines 0 comments Download
M net/url_request/url_request_job_factory_unittest.cc View 1 2 3 4 5 4 chunks +17 lines, -9 lines 0 comments Download
M net/url_request/url_request_job_manager.h View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
M net/url_request/url_request_job_manager.cc View 1 2 3 4 5 10 chunks +22 lines, -16 lines 0 comments Download
M net/url_request/url_request_redirect_job.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M net/url_request/url_request_redirect_job.cc View 1 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download
M net/url_request/url_request_simple_job.h View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_simple_job.cc View 1 2 3 4 5 6 1 chunk +3 lines, -4 lines 0 comments Download
M net/url_request/url_request_test_job.h View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M net/url_request/url_request_test_job.cc View 1 2 3 4 5 6 4 chunks +9 lines, -7 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 2 3 4 5 6 7 8 9 10 8 chunks +44 lines, -35 lines 0 comments Download
M webkit/appcache/appcache_interceptor.h View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_interceptor.cc View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_request_handler.h View 1 2 4 chunks +13 lines, -6 lines 0 comments Download
M webkit/appcache/appcache_request_handler.cc View 1 2 10 chunks +16 lines, -13 lines 0 comments Download
M webkit/appcache/appcache_request_handler_unittest.cc View 1 2 28 chunks +107 lines, -49 lines 0 comments Download
M webkit/appcache/appcache_update_job_unittest.cc View 1 9 chunks +30 lines, -16 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M webkit/appcache/appcache_url_request_job.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_url_request_job_unittest.cc View 1 2 7 chunks +21 lines, -12 lines 0 comments Download
M webkit/appcache/view_appcache_internals_job.h View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M webkit/appcache/view_appcache_internals_job.cc View 1 2 8 chunks +35 lines, -19 lines 0 comments Download
M webkit/blob/blob_url_request_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/blob/blob_url_request_job.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M webkit/blob/blob_url_request_job_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M webkit/blob/blob_url_request_job_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webkit/blob/blob_url_request_job_unittest.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M webkit/blob/view_blob_internals_job.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webkit/blob/view_blob_internals_job.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job_unittest.cc View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job_factory.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M webkit/fileapi/file_system_url_request_job_unittest.cc View 1 2 3 chunks +3 lines, -0 lines 0 comments Download
M webkit/fileapi/file_writer_delegate_unittest.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M webkit/fileapi/local_file_system_operation_write_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell.cc View 1 2 3 2 chunks +10 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
shalev
This CL changes over 100 files, but the changes are relatively straightforward and minor. Please ...
8 years, 4 months ago (2012-08-20 22:00:47 UTC) #1
erikwright (departed)
LGTM. I guess the one for making URLRequest take it as a constructor parameter will ...
8 years, 4 months ago (2012-08-21 02:05:01 UTC) #2
mmenke
LGTM. Just a couple headers that don't seem to be needed / needed any more. ...
8 years, 4 months ago (2012-08-21 15:28:48 UTC) #3
shalev
http://codereview.chromium.org/10855209/diff/1/chrome/browser/extensions/extension_protocols.cc File chrome/browser/extensions/extension_protocols.cc (right): http://codereview.chromium.org/10855209/diff/1/chrome/browser/extensions/extension_protocols.cc#newcode35 chrome/browser/extensions/extension_protocols.cc:35: #include "net/url_request/url_request_context.h" On 2012/08/21 02:05:01, erikwright wrote: > why ...
8 years, 4 months ago (2012-08-22 20:34:09 UTC) #4
mmenke
LGTM
8 years, 4 months ago (2012-08-22 20:37:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shalev@chromium.org/10855209/30012
8 years, 3 months ago (2012-08-23 22:44:07 UTC) #6
commit-bot: I haz the power
8 years, 3 months ago (2012-08-24 01:07:08 UTC) #7 
Change committed as 153133

Powered by Google App Engine
This is Rietveld 408576698