Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: net/url_request/url_request_ftp_job.h

Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Latest merge Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/url_request/url_request_filter_unittest.cc ('k') | net/url_request/url_request_ftp_job.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_ 5 #ifndef NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
6 #define NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_ 6 #define NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
(...skipping 13 matching lines...) Expand all
24 // provides an implementation for FTP. 24 // provides an implementation for FTP.
25 class URLRequestFtpJob : public URLRequestJob { 25 class URLRequestFtpJob : public URLRequestJob {
26 public: 26 public:
27 URLRequestFtpJob(URLRequest* request, 27 URLRequestFtpJob(URLRequest* request,
28 NetworkDelegate* network_delegate, 28 NetworkDelegate* network_delegate,
29 FtpTransactionFactory* ftp_transaction_factory, 29 FtpTransactionFactory* ftp_transaction_factory,
30 FtpAuthCache* ftp_auth_cache); 30 FtpAuthCache* ftp_auth_cache);
31 31
32 // TODO(shalev): get rid of this function in favor of FtpProtocolHandler. 32 // TODO(shalev): get rid of this function in favor of FtpProtocolHandler.
33 static URLRequestJob* Factory(URLRequest* request, 33 static URLRequestJob* Factory(URLRequest* request,
34 NetworkDelegate* network_delegate,
34 const std::string& scheme); 35 const std::string& scheme);
35 36
36 // Overridden from URLRequestJob: 37 // Overridden from URLRequestJob:
37 virtual bool GetMimeType(std::string* mime_type) const OVERRIDE; 38 virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;
38 virtual HostPortPair GetSocketAddress() const OVERRIDE; 39 virtual HostPortPair GetSocketAddress() const OVERRIDE;
39 40
40 private: 41 private:
41 virtual ~URLRequestFtpJob(); 42 virtual ~URLRequestFtpJob();
42 43
43 void StartTransaction(); 44 void StartTransaction();
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 77
77 FtpTransactionFactory* ftp_transaction_factory_; 78 FtpTransactionFactory* ftp_transaction_factory_;
78 FtpAuthCache* ftp_auth_cache_; 79 FtpAuthCache* ftp_auth_cache_;
79 80
80 DISALLOW_COPY_AND_ASSIGN(URLRequestFtpJob); 81 DISALLOW_COPY_AND_ASSIGN(URLRequestFtpJob);
81 }; 82 };
82 83
83 } // namespace net 84 } // namespace net
84 85
85 #endif // NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_ 86 #endif // NET_URL_REQUEST_URL_REQUEST_FTP_JOB_H_
OLDNEW
« no previous file with comments | « net/url_request/url_request_filter_unittest.cc ('k') | net/url_request/url_request_ftp_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698