Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1403)

Unified Diff: chrome/browser/profiles/off_the_record_profile_io_data.cc

Issue 10855209: Refactoring: ProtocolHandler::MaybeCreateJob takes NetworkDelegate as argument (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Latest merge Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/profiles/off_the_record_profile_io_data.cc
diff --git a/chrome/browser/profiles/off_the_record_profile_io_data.cc b/chrome/browser/profiles/off_the_record_profile_io_data.cc
index eca2df427a94cd1e69b093a59fa7cf8c826bc8ea..2e0b896783ae8378f826a71f035a946bb0968564 100644
--- a/chrome/browser/profiles/off_the_record_profile_io_data.cc
+++ b/chrome/browser/profiles/off_the_record_profile_io_data.cc
@@ -256,14 +256,15 @@ void OffTheRecordProfileIOData::LazyInitializeInternal(
extensions_job_factory_.reset(new net::URLRequestJobFactory);
int set_protocol = main_job_factory_->SetProtocolHandler(
- chrome::kFileScheme, new net::FileProtocolHandler(network_delegate()));
+ chrome::kFileScheme, new net::FileProtocolHandler());
DCHECK(set_protocol);
- // TODO(shalev): Without a network_delegate this protocol handler will never
+ // TODO(shalev): The extension_job_factory_ has a NULL NetworkDelegate.
+ // Without a network_delegate, this protocol handler will never
// handle file: requests, but as a side effect it makes
// job_factory::IsHandledProtocol return true, which prevents attempts to
// handle the protocol externally.
set_protocol = extensions_job_factory_->SetProtocolHandler(
- chrome::kFileScheme, new net::FileProtocolHandler(NULL));
+ chrome::kFileScheme, new net::FileProtocolHandler());
DCHECK(set_protocol);
set_protocol = main_job_factory_->SetProtocolHandler(
@@ -359,8 +360,7 @@ void OffTheRecordProfileIOData::CreateFtpProtocolHandler(
net::FtpAuthCache* ftp_auth_cache) const {
job_factory->SetProtocolHandler(
chrome::kFtpScheme,
- new net::FtpProtocolHandler(
- network_delegate(), ftp_factory_.get(), ftp_auth_cache));
+ new net::FtpProtocolHandler(ftp_factory_.get(), ftp_auth_cache));
}
chrome_browser_net::LoadTimeStats* OffTheRecordProfileIOData::GetLoadTimeStats(
« no previous file with comments | « chrome/browser/printing/print_dialog_cloud_interative_uitest.cc ('k') | chrome/browser/profiles/profile_impl_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698