Issue 10855152: Remove dev check for file chooser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10855152: Remove dev check for file chooser. (Closed)

Created:
8 years, 4 months ago by brettw

Modified:
8 years, 4 months ago

Reviewers:
Tom Sepez

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove dev check for file chooser. Disable the permissions check for dev interfaces in the PPAPI proxy. We don't currently use this check for anything, and it's breaking integrated Flash. We will need to work on getting the permissions correct. BUG=138902 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151541

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	content/renderer/pepper/content_renderer_pepper_host_factory.cc	View		1 chunk	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

brettw

I'm whacking this bug with a bigger hammer since my previous fix didn't seem to ...

8 years, 4 months ago (2012-08-14 17:19:59 UTC) #1

Tom Sepez

8 years, 4 months ago (2012-08-14 18:21:02 UTC) #2

LGTM.

https://chromiumcodereview.appspot.com/10855152/diff/1/content/renderer/peppe...
File content/renderer/pepper/content_renderer_pepper_host_factory.cc (right):

https://chromiumcodereview.appspot.com/10855152/diff/1/content/renderer/peppe...
content/renderer/pepper/content_renderer_pepper_host_factory.cc:43: /*if
(GetPermissions().HasPermission(ppapi::PERMISSION_DEV))*/ {
nit: just for my own education, what do our style guides say about commenting
out code via /* */ vs, say, #if 0 which seems less hacky to me.

Expand Messages | Collapse Messages