Remove dev check for file chooser.

content/renderer/pepper/content_renderer_pepper_host_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/pepper/content_renderer_pepper_host_factory.h"
 
 #include "base/logging.h"
 #include "content/renderer/pepper/pepper_file_chooser_host.h"
 #include "content/renderer/pepper/renderer_ppapi_host_impl.h"
 #include "ppapi/host/resource_host.h"
@@ skipping 18 matching lines @@
     const IPC::Message& message) {
   DCHECK(host == host_->GetPpapiHost());
 
   // Make sure the plugin is giving us a valid instance for this resource.
   if (!host_->IsValidInstance(instance))
     return scoped_ptr<ResourceHost>();
 
   // Resources for dev interfaces.
   // TODO(brettw) when we support any public or private interfaces, put them in
   // a separate switch above.
-  if (GetPermissions().HasPermission(ppapi::PERMISSION_DEV)) {
+
+  // TODO(brettw) put back this dev check! This was removed to fix issue 138902
+  // where the permissions for bundled Flash (but not Flash that you specify
+  // on the command line, making it difficult to test) are incorrect.
+  /*if (GetPermissions().HasPermission(ppapi::PERMISSION_DEV))*/ {

[Tom Sepez, 2012/08/14 18:21:02]

nit: just for my own education, what do our style guides say about commenting
out code via /* */ vs, say, #if 0 which seems less hacky to me.

     switch (message.type()) {
       case PpapiHostMsg_FileChooser_Create::ID:
         return scoped_ptr<ResourceHost>(new PepperFileChooserHost(
             host_, instance, params.pp_resource()));
     }
   }
   return scoped_ptr<ResourceHost>();
 }
 
 const ppapi::PpapiPermissions&
 ContentRendererPepperHostFactory::GetPermissions() const {
   return host_->GetPpapiHost()->permissions();
 }
 
 }  // namespace content