Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1734)

Unified Diff: content/renderer/pepper/content_renderer_pepper_host_factory.cc

Issue 10855152: Remove dev check for file chooser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/content_renderer_pepper_host_factory.cc
diff --git a/content/renderer/pepper/content_renderer_pepper_host_factory.cc b/content/renderer/pepper/content_renderer_pepper_host_factory.cc
index d5eb200d2658ed11789756b6348e42968433d08d..538fd9b285cb592f18739d7da3728c26b865ed35 100644
--- a/content/renderer/pepper/content_renderer_pepper_host_factory.cc
+++ b/content/renderer/pepper/content_renderer_pepper_host_factory.cc
@@ -36,7 +36,11 @@ scoped_ptr<ResourceHost> ContentRendererPepperHostFactory::CreateResourceHost(
// Resources for dev interfaces.
// TODO(brettw) when we support any public or private interfaces, put them in
// a separate switch above.
- if (GetPermissions().HasPermission(ppapi::PERMISSION_DEV)) {
+
+ // TODO(brettw) put back this dev check! This was removed to fix issue 138902
+ // where the permissions for bundled Flash (but not Flash that you specify
+ // on the command line, making it difficult to test) are incorrect.
+ /*if (GetPermissions().HasPermission(ppapi::PERMISSION_DEV))*/ {
Tom Sepez 2012/08/14 18:21:02 nit: just for my own education, what do our style
switch (message.type()) {
case PpapiHostMsg_FileChooser_Create::ID:
return scoped_ptr<ResourceHost>(new PepperFileChooserHost(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698